Bug #68672

Epic #86307: Extbase allows to fetch deleted/hidden records (respects ignoreEnableFields)

setIgnoreEnableFields() should be inherited to language overlays

Added by Martin R. Krause over 3 years ago. Updated 6 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Extbase + l10n
Target version:
-
Start date:
2015-07-31
Due date:
% Done:

0%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
hard
Is Regression:
No
Sprint Focus:

Description

Using the setIgnoreEnableFields() for query settings in an extbase repository fails, when the record gets an language overlay. It should be inherited to the overlay query.

The usage of the enable fields for the query of the language overlay is pretty much hardcoded in

typo3_src-6.2.12/typo3/sysext/frontend/Classes/Page/PageRepository.php:431

In addition the logic of the language overlay for Extbase record is inconsistent:

E.g.: Providing that starttime has l10n_mode "mergeIfNotBlank" (which is default), a translation of a record can be shown, even if its l10_parent is still hidden – only the enable fields of the translated record matter (which is OK). The other way around, requesting the record from an Extbase repository does not work, as both records (original and translation) need to allow for display of the record in order to show the translation.


Related issues

Related to TYPO3 Core - Bug #73007: Insufficient sysLanguageStatement does not respect enableFields for translations Needs Feedback 2016-01-29
Related to TYPO3 Core - Bug #84955: Extbase persistence layer ignores query settings New 2018-05-09

Associated revisions

Revision 8d4fe802 (diff)
Added by Tymoteusz Motylewski 6 months ago

[TASK] Provide more tests for Extbase rendering in languages

Some tests are just documenting current, buggy behavior.
So once bugs are fixed assertions needs to be updated.
See inline comments for details (and list of related issues below).

Resolves: #86327
Related: #45873
Related: #68672
Releases: master
Change-Id: I780f77fa95d3824a2dafd58a1a73df2bb5fac9e4
Reviewed-on: https://review.typo3.org/58276
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 9089da60 (diff)
Added by Tymoteusz Motylewski 6 months ago

[TASK] Provide more tests for Extbase rendering in languages

Some tests are just documenting current, buggy behavior.
So once bugs are fixed assertions needs to be updated.
See inline comments for details (and list of related issues below).

Resolves: #86327
Related: #45873
Related: #68672
Releases: master
Change-Id: I780f77fa95d3824a2dafd58a1a73df2bb5fac9e4
Reviewed-on: https://review.typo3.org/58357
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53445

#2 Updated by Peter Niederlag over 1 year ago

  • Related to Bug #73007: Insufficient sysLanguageStatement does not respect enableFields for translations added

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53445

#4 Updated by Benni Mack over 1 year ago

  • Category changed from Extbase to Extbase + l10n

#5 Updated by Tymoteusz Motylewski 6 months ago

  • Related to Bug #84955: Extbase persistence layer ignores query settings added

#6 Updated by Tymoteusz Motylewski 6 months ago

FYI, I have included tests from this review in https://review.typo3.org/#/c/58276/
to make it easier to fix this issue.

#7 Updated by Tymoteusz Motylewski 6 months ago

  • Parent task set to #86307

#8 Updated by Tymoteusz Motylewski 6 months ago

  • Status changed from Under Review to New

Also available in: Atom PDF