Bug #73007

Epic #86307: Extbase allows to fetch deleted/hidden records (respects ignoreEnableFields)

Insufficient sysLanguageStatement does not respect enableFields for translations

Added by Philipp Wrann over 3 years ago. Updated 4 months ago.

Status:
Needs Feedback
Priority:
Must have
Assignee:
-
Category:
Extbase + l10n
Start date:
2016-01-29
Due date:
% Done:

0%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The statement added to sql queries to load translated entities only respects the deleted falg.

If you define the starttime, endtime, hidden and feaccess features for translations no filters are applied on queries.

This results in a QueryResult containing a number of X Rows.

After mapping those elements will be hidden because in languageOverlay the fields ARE respected.

In my case i display the number of results found by the orm, followed by a paginated widget showing those results.

So it says "11 Results found"

But only 6 Results are rendered.

The Problem can be found in:
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php#L733

If additional enablefields are configured and not set as l10n_mode=exclude they must be appended as well.

This can be solved without touching anything else in the translation setup, a patch would only affect the subquery statement

The bug exists in 6.2 and 7 LTS


Related issues

Related to TYPO3 Core - Bug #76974: Translation handling with starttime/stoptime New 2016-07-07
Related to TYPO3 Core - Bug #68672: setIgnoreEnableFields() should be inherited to language overlays New 2015-07-31
Related to TYPO3 Core - Bug #84955: Extbase persistence layer ignores query settings New 2018-05-09
Duplicated by TYPO3 Core - Bug #81040: Extbase QueryResult::count() incorrect for strict language mode Closed 2017-04-27

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46348

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46348

#3 Updated by Mathias Schreiber over 3 years ago

  • Status changed from Under Review to New

#4 Updated by Markus Klein almost 3 years ago

  • Status changed from New to Accepted

#5 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52072

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52097

#7 Updated by Cornel Widmer about 2 years ago

  • Related to Bug #76974: Translation handling with starttime/stoptime added

#8 Updated by Axel Helmert about 2 years ago

  • Duplicated by Bug #81040: Extbase QueryResult::count() incorrect for strict language mode added

#9 Updated by Peter Niederlag almost 2 years ago

  • Related to Bug #68672: setIgnoreEnableFields() should be inherited to language overlays added

#10 Updated by Riccardo De Contardi almost 2 years ago

  • Category changed from Extbase to Extbase + l10n

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52097

#12 Updated by Tymoteusz Motylewski 9 months ago

  • Related to Bug #84955: Extbase persistence layer ignores query settings added

#13 Updated by Tymoteusz Motylewski 9 months ago

  • Parent task set to #86307

#14 Updated by Susanne Moog 4 months ago

  • Status changed from Under Review to Needs Feedback

Review was abandoned and maybe fixed in the mean time. Please check if the issue still persists in current TYPO3 versions.

Also available in: Atom PDF