Project

General

Profile

Actions

Bug #78767

closed

Bad usability of workspace diff

Added by Andreas Kiessling over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2016-11-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The code to generate the workspace diff was changed in #69904 (TYPO3 7.5)

The diff view is now passed through strip_tags and handed over to cogpowered/finediff. Before, tags were not stripped and the diff was done through calling diff on the shell and displayed only changes, not the whole text block.
When you now view a simple block of RTE text, all tags like "link" are missing, but also changes like <h2> to <h3> are not shown. So you don't really get a html-diff of what you are about to publish but rather a text-diff.

IMHO, this is a big regression for the workspace module and needs a rework, even if it means replacing finediff with yet another diff engine, that can hopefully diff html structures and display the differences in a usable way.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #69904: Use 3rd party diff utilityClosedMathias Schreiber2015-09-16

Actions
Has duplicate TYPO3 Core - Bug #79205: CE HTML: History must show HTML Content differencesClosedGeorg Ringer2017-01-08

Actions
Actions #1

Updated by Riccardo De Contardi about 7 years ago

  • Category set to Backend User Interface
Actions #2

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51220

Actions #3

Updated by Georg Ringer about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51933

Actions #5

Updated by Georg Ringer almost 7 years ago

  • Status changed from Under Review to Resolved
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF