Bug #78767
closedBad usability of workspace diff
100%
Description
The code to generate the workspace diff was changed in #69904 (TYPO3 7.5)
The diff view is now passed through strip_tags and handed over to cogpowered/finediff. Before, tags were not stripped and the diff was done through calling diff on the shell and displayed only changes, not the whole text block.
When you now view a simple block of RTE text, all tags like "link" are missing, but also changes like <h2> to <h3> are not shown. So you don't really get a html-diff of what you are about to publish but rather a text-diff.
IMHO, this is a big regression for the workspace module and needs a rework, even if it means replacing finediff with yet another diff engine, that can hopefully diff html structures and display the differences in a usable way.
Updated by Riccardo De Contardi almost 8 years ago
- Category set to Backend User Interface
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51220
Updated by Georg Ringer almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a3ced22a29f2279d21b0c05d5da99e9001e22592.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51933
Updated by Georg Ringer almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 025030f2449ebbf71b5505095f05961b844d4ae0.