Bug #70146

Story #69617: FormEngine bugs

Input placeholder record traversal is broken

Added by Sebastian Michaelsen over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Must have
Category:
FormEngine aka TCEforms
Target version:
Start date:
2015-09-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

I have a TCA field like this:

        'seats' => [
            'label' => $lll . '.seats',
            'config' => [
                'type' => 'input',
                'size' => 4,
                'placeholder' => '__row|tour|default_seats'
            ],
        ],

Which is broken since the FormEngine refactoring (b524fc86). It works on the commit before, but after the refactoring I get this:


http://shots.michaelsen.io/KJVg


Files

tripshop.tar.bz (8.3 KB) tripshop.tar.bz Morton Jonuschat, 2015-10-31 16:30

Related issues

Related to TYPO3 Core - Bug #70297: Placeholder config with default value of related record field failsClosedMorton Jonuschat2015-10-02

Actions
#1

Updated by Morton Jonuschat over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Morton Jonuschat
#2

Updated by Morton Jonuschat over 5 years ago

  • Parent task set to #69617
#3

Updated by Gerrit Code Review over 5 years ago

  • Status changed from In Progress to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43748

#4

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43748

#5

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43748

#6

Updated by Morton Jonuschat over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Sebastian Michaelsen over 5 years ago

  • Status changed from Resolved to New

Sorry, not solved for me. The field configuration now is:

'seats' => [
    'label' => $lll . '.seats',
    'config' => [
        'type' => 'input',
        'size' => 4,
        'placeholder' => '__row|tour|default_seats',
        'eval' => 'null',
        'mode' => 'useOrOverridePlaceholder'
    ],
],

And I get the following exception:


http://shots.michaelsen.io/KWLU

For me it looks like the problem occurs when there is no related record configured. In my case the record has no tour. That's why it ends up trying to load the tour with uid 0. When there's no tour associated the placeholder should be blank.

#8

Updated by Wouter Wolters over 5 years ago

  • Status changed from New to Needs Feedback

Is this resolved now?

#9

Updated by Christian Kuhn over 5 years ago

  • Target version set to 7 LTS
#10

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44440

#11

Updated by Morton Jonuschat over 5 years ago

Added extension for verification

#12

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44440

#13

Updated by Morton Jonuschat over 5 years ago

  • Status changed from Under Review to Resolved
#14

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF