Bug #70146: Input placeholder record traversal is broken - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #70146

closed

Story #69617: FormEngine bugs

Input placeholder record traversal is broken

Added by Sebastian Michaelsen over 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Morton Jonuschat

Category:

FormEngine aka TCEforms

Target version:

7 LTS

Start date:

2015-09-28

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

I have a TCA field like this:

        'seats' => [
            'label' => $lll . '.seats',
            'config' => [
                'type' => 'input',
                'size' => 4,
                'placeholder' => '__row|tour|default_seats'
            ],
        ],

Which is broken since the FormEngine refactoring (b524fc86). It works on the commit before, but after the refactoring I get this:

http://shots.michaelsen.io/KJVg

Files

tripshop.tar.bz (8.3 KB) tripshop.tar.bz

Morton Jonuschat, 2015-10-31 16:30

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Morton Jonuschat over 8 years ago

Status changed from New to In Progress
Assignee set to Morton Jonuschat

Actions

Copy link

Updated by Morton Jonuschat over 8 years ago

Parent task set to #69617

Actions

Copy link

Updated by Gerrit Code Review over 8 years ago

Status changed from In Progress to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43748

Actions

Copy link

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43748

Actions

Copy link

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43748

Actions

Copy link

Updated by Morton Jonuschat over 8 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 13177fa0e0da2b879db03859bc9cb4f8716bfdc3.

Actions

Copy link

Updated by Sebastian Michaelsen over 8 years ago

Status changed from Resolved to New

Sorry, not solved for me. The field configuration now is:

'seats' => [
    'label' => $lll . '.seats',
    'config' => [
        'type' => 'input',
        'size' => 4,
        'placeholder' => '__row|tour|default_seats',
        'eval' => 'null',
        'mode' => 'useOrOverridePlaceholder'
    ],
],

And I get the following exception:

http://shots.michaelsen.io/KWLU

For me it looks like the problem occurs when there is no related record configured. In my case the record has no tour. That's why it ends up trying to load the tour with uid 0. When there's no tour associated the placeholder should be blank.

Actions

Copy link

Updated by Wouter Wolters over 8 years ago

Status changed from New to Needs Feedback

Is this resolved now?

Actions

Copy link

Updated by Christian Kuhn over 8 years ago

Target version set to 7 LTS

Actions

Copy link

#10

Updated by Gerrit Code Review over 8 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44440

Actions

Copy link

#11

Updated by Morton Jonuschat over 8 years ago

File tripshop.tar.bz tripshop.tar.bz added

Added extension for verification

Actions

Copy link

#12

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44440

Actions

Copy link

#13