Bug #70951
closed
Story #69617: FormEngine bugs
PHP Warning while calling renderForeignRecordHeader
100%
Description
Hello Core-Team,
in case of restructuring the TCA all values for selct-fields are of type array now. I know, we can't revert it, but we have to update the related code.
Example:
InlineRecordContainer::renderForeignRecordHeader() at line 358 we have following:
$valueParts = GeneralUtility::trimExplode('|', $rec[$titleCol]);
In my case the field was declared as type "inline", so $rec[$titleCol] returns an array now, which results in following warning:
PHP Warning: explode() expects parameter 2 to be string, array given
Stefan
Updated by Oliver Hader over 8 years ago
Stefan, can you please provide a patch for that and push it to Gerrit? It seems that you already had changed these things on your side, so why not just pushing it to the accordant place at review.typo3.org? Thx! :)
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44254
Updated by Stefan Froemken over 8 years ago
Hi Olli,
I only have mentioned one example and I have titled it as "Example". How many problems of this case we have in TYPO3 Core? 50? 100? Since the refactoring I just have found two of them and solved one. With this ticket I wanted to start a task to search for further problems of this type. So IMO this ticket is not solveable with a 3 letter change.
So what's next? Should I/We/Community create a new patch for each kind of this problem? If yes, than you're right and I can solve and push a solution within seconds.
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44254
Updated by Christian Kuhn over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
was resolved with the solution from the related issue.
Updated by Gerrit Code Review over 8 years ago
- Status changed from Resolved to Under Review
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44254
Updated by Mathias Schreiber over 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 96fabbf06587cd85634ca8c5eb6bea30d1f00714.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed