Feature #72053: Extbase: Support \DateTimeInterface instead of \DateTime - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Feature #72053

closed

Epic #77562: Misbehaviors with datetime values and timezones

Extbase: Support \DateTimeInterface instead of \DateTime

Added by Sebastian Michaelsen over 8 years ago. Updated almost 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Extbase

Target version:

Start date:

2015-12-04

Due date:

% Done:

100%

Estimated time:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Extbase supports conversion from and to \DateTime objects in several situations. But you cannot work with \DateTimeImmutable or other implementations of the \DateTimeInterface.
Extbase should support working with the interface instead of the concrete class.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Sebastian Michaelsen over 8 years ago

Target version set to 8 LTS

Actions

Copy link

Updated by Sebastian Michaelsen over 8 years ago

As far as I see this would affect the following things would need to be changed:

Wrong: When loading a database record into a model object, the DataMapper creates a \DateTime object even when the property is annotated as \DateTimeImmutable.
Wrong: When saving a model to the database the \TYPO3\CMS\Extbase\Persistence\Generic\Backend results in an exception because ->getPlainValue() doesn't convert \DateTimeImmutable to a timestamp.
More or less right: The DateTimeConverter doesn't force \DateTime but performs duck typing (is_callable(array($targetType, 'createFromFormat'))). But the override feature (->overrideTimeIfSpecified()) forces the first paramter to be \DateTime.

Actions

Copy link

Updated by Riccardo De Contardi about 7 years ago

Target version changed from 8 LTS to 9.0

Actions

Copy link

Updated by Mona Muzaffar about 7 years ago

Related to Epic #80852: Datetime handling in backend added

Actions

Copy link

Updated by Riccardo De Contardi almost 7 years ago

Parent task set to #77562

Actions

Copy link

Updated by Riccardo De Contardi almost 7 years ago

Related to deleted (Epic #80852: Datetime handling in backend)

Actions

Copy link

Updated by Susanne Moog about 6 years ago

Target version deleted (~~9.0~~)

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57388

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57388

Actions

Copy link

#10

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57388

Actions

Copy link

#11

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57388

Actions

Copy link

#12

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57388

Actions

Copy link

#13

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57388

Actions

Copy link

#14