Bug #72307

Story #69617: FormEngine bugs

Flexform displayCond not evaluated correctly when not in first sheet

Added by Philipp Wrann almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2015-12-18
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

I recently noticed some bug similiar to this one:
https://forge.typo3.org/issues/67879

If i place displayCond as in the example below in the first sheet of a flexform it gets evaluated.
If i place it in the second sheet the field is not visible, even the condition is met.

<settings.facets>
<TCEforms>
<label>LLL:EXT:XXX/Resources/Private/Language/locallang.xlf:flexform.facets</label>
<displayCond><![CDATA[FIELD:switchableControllerActions:=:Document->index]]></displayCond>
<config>
<type>check</type>
<default>0</default>
</config>
</TCEforms>
</settings.facets>

Further displayConditions regarding the switchableControllerActions are not displayed on default values, so if the default value is set and it is valid for a displaycondition the field will not be displayed anyway - only on the initial creation of a new element.

If you save the new record with default values the condition is evaluated correctly.

This seems to be connected to:
https://forge.typo3.org/issues/45791

TYPO3 Version is 7.6.1

example-flexform.xml View (7.92 KB) Philipp Wrann, 2015-12-18 09:57


Related issues

Related to Grid Elements (former official tracker) - now moved to Gitlab! - Bug #75899: Issue: GridElement > Flexform > Display Cond Rejected 2016-04-25

Associated revisions

Revision 38a1bc5d (diff)
Added by Christian Kuhn almost 3 years ago

[!!!][TASK] Improve flex and TCA handling in FormEngine

The patch adapts a series of nasty form engine areas to more solid
code. The evaluate condition code is rewritten and works much better
in flex form scenarios. The suggest wizard and svg tree are much
more solid in flex forms. The group element is rewritten
towards a better readable and easier to refactor code, dropping
method dbFileIcons(). A bunch of issues is resolved along the way.

  • TCA "default" now works in flex form section container elements
  • The "displayCond" parser is now strict and throws exceptions on
    invalid syntax and wrong referenced fields to help debugging
    faulty display conditions
  • TCA displayCond on flex fields can now be prefixed with the
    sheet name and can reference field values from neighbor sheets
  • TCA displayCond now works with flex section containers
  • TCA flex section container now throw an exception if select or
    group fields configure a MM relation - this is not supported
  • TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed
    not only on flex form fields, but also on normal columns fields
  • TCA tree now works as section container element and initializes
    correctly on new records and new containers
  • GroupElement rewrite to drop dbFileIcons()
  • config option maxitems now optional for type=group and type=select
    and defaults to "many items allowed"
  • inline now works in "fancy" flex situations with "new" records
    by handing the final dataStructureIdentifier around
  • FormEngine no longer loads extJS

Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd
Resolves: #78899
Resolves: #72307
Resolves: #75646
Resolves: #76637
Resolves: #72106
Resolves: #78824
Resolves: #76793
Resolves: #68247
Resolves: #69715
Related: #78460
Related: #67198
Related: #72294
Releases: master
Reviewed-on: https://review.typo3.org/50879
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Morton Jonuschat almost 4 years ago

  • Category changed from DataHandler aka TCEmain to FormEngine aka TCEforms
  • Status changed from New to Needs Feedback
  • Target version deleted (7 LTS)

Hi Philipp,

afaik this is the intended behavior. DisplayCond in FlexForm has two "levels". If you use a displayCond to decide wether a whole sheet should be shown/hidden then you have access to the values of all sheets using FIELD:sheetName.fieldName, if you use displayCond on on a field you only have access to the fields on that sheet (plus the database fields with parentRec.fieldName). Your example tries to access the field "switchableControllerActions" from one sheet within another sheet, which is why it's not working.

Did this work before? If so could you point me to the version of TYPO3?

#2 Updated by Philipp Wrann almost 4 years ago

Ahhhh thank you Morton! I simply did not know that!

But dont close this, the second problem regarding the default value not be be evaluated as true on record-creation remains...

#3 Updated by Philipp Wrann almost 4 years ago

Cant get it working...

Same sheet (sDEF) displaycond: <displayCond><![CDATA[FIELD:sDEF.switchableControllerActions:=:Document->list]]></displayCond> does NOT work
Same sheet (sDEF) displaycond: <displayCond><![CDATA[FIELD:switchableControllerActions:=:Document->list]]></displayCond> does work
Other sheet: <displayCond><![CDATA[FIELD:sDEF.switchableControllerActions:=:Document->list]]></displayCond> does NOT work
Other sheet: <displayCond><![CDATA[FIELD:switchableControllerActions:=:Document->list]]></displayCond> does NOT work

Also displayConditions are NOT evaluated correctly with default values.

So is this a bug or am i still wrong?

#4 Updated by Mathias Schreiber over 3 years ago

  • Parent task set to #69617

#5 Updated by Alexander Opitz over 3 years ago

  • Status changed from Needs Feedback to New

#6 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#7 Updated by Gerrit Code Review almost 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#8 Updated by Gerrit Code Review almost 3 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#9 Updated by Gerrit Code Review almost 3 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#10 Updated by Gerrit Code Review almost 3 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#11 Updated by Gerrit Code Review almost 3 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#12 Updated by Gerrit Code Review almost 3 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#13 Updated by Gerrit Code Review almost 3 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#14 Updated by Gerrit Code Review almost 3 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#15 Updated by Gerrit Code Review almost 3 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#16 Updated by Gerrit Code Review almost 3 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#17 Updated by Gerrit Code Review almost 3 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#18 Updated by Gerrit Code Review almost 3 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#19 Updated by Gerrit Code Review almost 3 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#20 Updated by Gerrit Code Review almost 3 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#21 Updated by Gerrit Code Review almost 3 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#22 Updated by Gerrit Code Review almost 3 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#23 Updated by Gerrit Code Review almost 3 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#24 Updated by Gerrit Code Review almost 3 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#25 Updated by Gerrit Code Review almost 3 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#26 Updated by Gerrit Code Review almost 3 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#27 Updated by Gerrit Code Review almost 3 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#28 Updated by Gerrit Code Review almost 3 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#29 Updated by Gerrit Code Review almost 3 years ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#30 Updated by Gerrit Code Review almost 3 years ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#31 Updated by Gerrit Code Review almost 3 years ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#32 Updated by Gerrit Code Review almost 3 years ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#33 Updated by Gerrit Code Review almost 3 years ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#34 Updated by Gerrit Code Review almost 3 years ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#35 Updated by Gerrit Code Review almost 3 years ago

Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#36 Updated by Gerrit Code Review almost 3 years ago

Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#37 Updated by Gerrit Code Review almost 3 years ago

Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50879

#38 Updated by Christian Kuhn almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#39 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF