Bug #75647

Story #69617: FormEngine bugs

hardcoded "hidden" col in backend/form creates wrong SQL

Added by Stefan Froemken almost 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2016-04-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hello Core-Team,

if you have a record with an inline-relation to be_users and that inline record is collapsed (<---notloaded--> in HTML-comment) and you save that record, then a SQL-Error appears: col "hidden" not found in be_users.

In InlineRecordContainer.php you're working with hardcoded "hidden" cols:

PS: If you save the record with expanded inline-records it works like expected.

if (!$data['isInlineChildExpanded']
  && !empty($GLOBALS['TCA'][$foreignTable]['ctrl']['enablecolumns']['disabled'])
) {
$checked = !empty($record['hidden']) ? ' checked="checked"' : '';
$html .= '<input type="checkbox" data-formengine-input-name="data'
  . htmlspecialchars($appendFormFieldNames)
  . '[hidden]" value="1"' . $checked . ' />';
  $html .= '<input type="input" name="data' . htmlspecialchars($appendFormFieldNames)
  . '[hidden]" value="' . htmlspecialchars($record['hidden']) . '" />';
}

Stefan

#1

Updated by Benni Mack almost 5 years ago

  • Parent task set to #69617
#2

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47888

#3

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47888

#4

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47888

#5

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47888

#6

Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47888

#7

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47889

#8

Updated by Wouter Wolters almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47892

#10

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47889

#11

Updated by Christian Kuhn almost 5 years ago

  • Status changed from Under Review to Resolved
#12

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF