Project

General

Profile

Actions

Bug #76232

closed

Story #69617: FormEngine bugs

IconFactory::getIconForRecord() throws an exception in some cases (contrary to former feedback)

Added by Petra Arentzen about 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2016-05-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Contrary to my former feedback for bug #75271 the exception occurred again (Now tested in 7.6.6 and 7.6.7)

I can tell that the problem occurrs with the following TCA column configuration:

                'type' => 'group',
                'internal_type' => 'db',
                'allowed' => 'my_relation_table',
                'prepend_tname' => 0,
               'show_thumbs' => '1',

It's because in TYPO3\CMS\Backend\Form\Element\GroupElement::render() line 275 spliting is done for db value

list($this_table, $this_uid) = BackendUtility::splitTable_Uid($recordParts[0]);

But because 'prepend_tname' is false there is no table name. The value then only contains a number but not a table name.

I added this after the line obove to solve the problem and it worked for me!


                    // if 'prepend_tname' is false $this_table is empty
                    if (!$this_table) {
                        $this_table = reset($allowed);
                    }


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #75271: TYPO3\CMS\Core\Imaging\IconFactory::getIconForRecord() throws an exception in some casesClosed2016-03-25

Actions
Actions #1

Updated by Markus Klein about 8 years ago

  • Subject changed from TYPO3\CMS\Core\Imaging\IconFactory::getIconForRecord() throws an exception in some cases (contrary to former feedback) to IconFactory::getIconForRecord() throws an exception in some cases (contrary to former feedback)

Hi Petra!

Thanks for your report. Can you maybe push a patch for the issue to our review system?
Could you maybe even extend our Testing-Extension ext:styleguide [1] with your test-case?

[1] https://github.com/7elix/TYPO3.CMS.Styleguide

Actions #2

Updated by Petra Arentzen about 8 years ago

Hi Markus!

I would love to do that, but I've never worked with the review system. Can you provide me with stuff like Howtos / Tutorials / Documentation?

Thanks in advance

Petra

Actions #3

Updated by Markus Klein about 8 years ago

Hi!

Sure: Check https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/
For questions please get in touch with us on Slack. We will happily guide you through!

Actions #4

Updated by Christian Kuhn about 8 years ago

  • Parent task set to #69617
Actions #5

Updated by Petra Arentzen about 8 years ago

  • Assignee set to Petra Arentzen
Actions #6

Updated by Petra Arentzen about 8 years ago

  • % Done changed from 0 to 10
Actions #7

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48294

Actions #8

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #9

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #10

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #11

Updated by Gerrit Code Review about 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #12

Updated by Gerrit Code Review about 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #13

Updated by Gerrit Code Review about 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #14

Updated by Gerrit Code Review about 8 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #15

Updated by Gerrit Code Review about 8 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #16

Updated by Gerrit Code Review about 8 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #17

Updated by Gerrit Code Review about 8 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #18

Updated by Gerrit Code Review about 8 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765

Actions #19

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49091

Actions #20

Updated by Petra Arentzen about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 10 to 100
Actions #21

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49110

Actions #22

Updated by Wouter Wolters about 8 years ago

  • Status changed from Under Review to Resolved
Actions #23

Updated by Benni Mack almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF