Bug #76232
closed
Story #69617: FormEngine bugs
IconFactory::getIconForRecord() throws an exception in some cases (contrary to former feedback)
100%
Description
Contrary to my former feedback for bug #75271 the exception occurred again (Now tested in 7.6.6 and 7.6.7)
I can tell that the problem occurrs with the following TCA column configuration:
'type' => 'group',
'internal_type' => 'db',
'allowed' => 'my_relation_table',
'prepend_tname' => 0,
'show_thumbs' => '1',
It's because in TYPO3\CMS\Backend\Form\Element\GroupElement::render() line 275 spliting is done for db value
list($this_table, $this_uid) = BackendUtility::splitTable_Uid($recordParts[0]);
But because 'prepend_tname' is false there is no table name. The value then only contains a number but not a table name.
I added this after the line obove to solve the problem and it worked for me!
// if 'prepend_tname' is false $this_table is empty
if (!$this_table) {
$this_table = reset($allowed);
}
Updated by Markus Klein over 8 years ago
- Subject changed from TYPO3\CMS\Core\Imaging\IconFactory::getIconForRecord() throws an exception in some cases (contrary to former feedback) to IconFactory::getIconForRecord() throws an exception in some cases (contrary to former feedback)
Hi Petra!
Thanks for your report. Can you maybe push a patch for the issue to our review system?
Could you maybe even extend our Testing-Extension ext:styleguide [1] with your test-case?
Updated by Petra Arentzen over 8 years ago
Hi Markus!
I would love to do that, but I've never worked with the review system. Can you provide me with stuff like Howtos / Tutorials / Documentation?
Thanks in advance
Petra
Updated by Markus Klein over 8 years ago
Hi!
Sure: Check https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/
For questions please get in touch with us on Slack. We will happily guide you through!
Updated by
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48294
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48765
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49091
Updated by Petra Arentzen over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 10 to 100
Applied in changeset 451b4903ef93f6ce957adb48279dff7e71f0fcd3.
Updated by Gerrit Code Review over 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49110
Updated by Wouter Wolters over 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset e8fbf240ec585ccd90e78a9187c5ed5cd5c26734.
Updated by