Bug #76374
closed
Select trees not rendered on inline records
100%
Description
Since the change in #75519 the tree rendering of TCA select is broken for records managed inline.
The change was determined via Git bisecting between TYPO3 6.2.21 and 6.2.22.
See the attached test extension for an example. It adds a single inline relation field to the sys_category table which uses a tree for its parent field. Try to add a relation and see that the tree of the parent field is missing.
Files
Updated by Mathias Brodala almost 8 years ago
- File 6.2.21.png 6.2.21.png added
- File 6.2.22.png 6.2.22.png added
Updated by Mathias Brodala almost 8 years ago
The issue only occurs for records created/loaded via AJAX; if a record is already stored and thus opened on editing the parent record, the tree is rendered just fine.
Updated by Mark Herzberg almost 8 years ago
- File tree.js.diff tree.js.diff added
To prevent this behavior I added a simple check if Ext.fly('treeinput' + this.id) exists. Have a look at the attached diff.
Updated by Mathias Brodala almost 8 years ago
I just tried and it fixes loading of trees within inline records. But at the same time checking items doesn't work at all. Already checked items are kept but you cannot check items. If you uncheck a checked item, you cannot re-check it again.
Updated by Henrik Ziegenhain almost 8 years ago
Attached Patch is working for me.
The second issue mentioned by Mathias seems to be resolved with #75947 in the meanwhile.
Tested with 6.2.25 - can we bring it to next patchlevel?
Updated by Tymoteusz Motylewski over 7 years ago
seems that the test extension is broken.
I'm getting "'Unknown column 'related_category' in 'field list'' "
lastBuiltQuery => 'SELECT uid,sys_language_uid,l10n_parent,parent,items,images,single_pid,short
cut,related_category,deleted FROM sys_category WHERE uid=257 LIMIT 1'
Updated by Mathias Brodala over 7 years ago
The test extension was missing DB schema updates.
Updated by Mathias Brodala over 7 years ago
- File deleted (
test_category_inline_tree.zip)
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49684
Updated by Tymoteusz Motylewski over 7 years ago
- TYPO3 Version changed from 6.2 to 8
Can not confirm the issue with v7.6.9, works perfectly there.
It's not a priority bugfix, so it will not go into 6.2
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49684
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49684
Updated by Tymoteusz Motylewski over 7 years ago
Testing instructions¶
- install the attached extension
- edit category record
- add inline relation at the bottom of the record (related_category field)
- without the patch, the category tree is not rendered in the inline child
Updated by Tymoteusz Motylewski over 7 years ago
- Target version changed from next-patchlevel to 8.4
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49684
Updated by Tymoteusz Motylewski over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d69e182b56c1a1216faafcec3fd507404459f586.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed