Epic #67261: Declutter GeneralUtility
Deprecate GeneralUtility::strtoupper & strtolower
The following methods of GeneralUtility should be deprecated:
[TASK] Deprecate methods strtolower & strtoupper of GeneralUtility
In favor of CharsetConverter and the native implementation, the
following methods of GeneralUtility have been deprecated:
Tested-by: Bamboo TYPO3com <firstname.lastname@example.org>
Reviewed-by: Christian Kuhn <email@example.com>
Tested-by: Christian Kuhn <firstname.lastname@example.org>
Reviewed-by: Markus Klein <email@example.com>
Tested-by: Markus Klein <firstname.lastname@example.org>
#8 Updated by Ernesto Baschny almost 3 years ago
How should that work with locale tr_TR? There is no upper-case "i" in that locale. Thats the main reason we introduced GeneralUtility::strtoupper in the first place, to make sure it works regardless of locale on all ASCII chars.
Just try that out:
<?php setlocale(LC_CTYPE, 'tr_TR.utf8'); echo strtoupper('abcdi') . "\n";
The locale can be set in TypoScript by the user (config.locale_all). This broke many turkish sites back then (I think it was introduced with PHP 5.3). This still works like that in PHP 7 (at least under Linux - not on Mac!).
Maybe I am missing something?
#9 Updated by Ernesto Baschny almost 3 years ago
I mean specifically these kind of changes have the potential to break: