Task #76804
closed
Epic #67261: Declutter GeneralUtility
Deprecate GeneralUtility::strtoupper & strtolower
100%
Description
The following methods of GeneralUtility should be deprecated:
- strtoupper
- strtolower
Updated by
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832
Updated by Gerrit Code Review almost 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832
Updated by Gerrit Code Review almost 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832
Updated by Georg Ringer almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 202448c7b2c275f508b7bd6ffdd5044cf1aa4fb3.
Updated by Ernesto Baschny over 7 years ago
Post-Review:
How should that work with locale tr_TR? There is no upper-case "i" in that locale. Thats the main reason we introduced GeneralUtility::strtoupper in the first place, to make sure it works regardless of locale on all ASCII chars.
Just try that out:
<?php
setlocale(LC_CTYPE, 'tr_TR.utf8');
echo strtoupper('abcdi') . "\n";
The locale can be set in TypoScript by the user (config.locale_all). This broke many turkish sites back then (I think it was introduced with PHP 5.3). This still works like that in PHP 7 (at least under Linux - not on Mac!).
Maybe I am missing something?
Updated by Ernesto Baschny over 7 years ago
I mean specifically these kind of changes have the potential to break:
Updated by Benni Mack about 7 years ago
- Target version set to Candidate for Major Version