TYPO3 Core

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48832

Post-Review:

How should that work with locale tr_TR? There is no upper-case "i" in that locale. Thats the main reason we introduced GeneralUtility::strtoupper in the first place, to make sure it works regardless of locale on all ASCII chars.

Just try that out:

<?php
setlocale(LC_CTYPE, 'tr_TR.utf8');
echo strtoupper('abcdi') . "\n";

The locale can be set in TypoScript by the user (config.locale_all). This broke many turkish sites back then (I think it was introduced with PHP 5.3). This still works like that in PHP 7 (at least under Linux - not on Mac!).

Maybe I am missing something?

I mean specifically these kind of changes have the potential to break:

https://review.typo3.org/#/c/48832/5/typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php,unified