Feature #77268

Leaving edit by clicking in page tree does not show a warning

Added by Edward Lenssen about 3 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
-
Start date:
2016-07-27
Due date:
% Done:

100%

PHP Version:
Tags:
JavaScript
Complexity:
Sprint Focus:
On Location Sprint

Description

Especially new editors are exploring TYPO3.

We regularly see editors make changes in for example a content field. They do not save yet. Then for example they click at another page in page tree to look something up. All their changes are lost as no warning shows up.

Would be great if same warning shows up as when closing the edit of an item in stead of saving.

leaving edit by close.png View (55.3 KB) Edward Lenssen, 2016-07-27 11:33

leaving edit by clicking in page tree.png View (39.2 KB) Edward Lenssen, 2016-07-27 11:33


Related issues

Related to TYPO3 Core - Bug #5368: Ask for saving, if record is not explicitly closed Closed 2009-11-15
Related to TYPO3 Core - Bug #81360: FieldControl Wizards: check for unsaved changes not always working Closed 2017-05-29
Related to TYPO3 Core - Bug #68955: Confirm message on closing an editform with unsaved changes doesn't respect changes in RTE fields Closed 2015-08-11

Associated revisions

Revision 72edfd5e (diff)
Added by Oliver Hader over 2 years ago

[FEATURE] Leaving edit by clicking in page tree does not show a warning

If edit forms have unsaved changes, changing the IFRAME URL is caught by
explicitly sending interaction requests that are handled by individual
client components, such as the FormEngine. This feature does not use the
Window.beforeunload event, but some custom messaging API instead.

Click events on the ExtJS page-tree are caught if those trigger a change
request for the content component, however highlighting the clicked page
node is not caught due to nested ExtJS event hierarchies.

Resolves: #77268
Releases: master
Change-Id: I3e2359cf27d95197b17e8d8489759ace403ce1af
Reviewed-on: https://review.typo3.org/53075
Tested-by: TYPO3com <>
Tested-by: Jasmina LieƟmann Reviewed-by: Frank Naegler <frank.naegler@typo3.org> Tested-by: Frank Naegler <frank.naegler@typo3.org> Reviewed-by: Susanne Moog <susanne.moog@typo3.org> Tested-by: Susanne Moog <susanne.moog@typo3.org>

History

#1 Updated by Riccardo De Contardi almost 3 years ago

  • Category set to Backend User Interface

#2 Updated by Benjamin Kott over 2 years ago

  • Status changed from New to Accepted
  • Sprint Focus set to On Location Sprint

#3 Updated by Oliver Hader over 2 years ago

  • Tags set to JavaScript

#4 Updated by Oliver Hader over 2 years ago

  • Status changed from Accepted to In Progress
  • Assignee set to Oliver Hader

#5 Updated by Susanne Moog over 2 years ago

  • Related to Bug #5368: Ask for saving, if record is not explicitly closed added

#6 Updated by Ralf Hettinger over 2 years ago

  • Related to Bug #81360: FieldControl Wizards: check for unsaved changes not always working added

#7 Updated by Ralf Hettinger over 2 years ago

I'd think that the patch pending in #81360 might be helpful to use the unsaved changes warning modal box to be triggered in different contexts

#8 Updated by Ralf Hettinger over 2 years ago

  • Related to Bug #68955: Confirm message on closing an editform with unsaved changes doesn't respect changes in RTE fields added

#9 Updated by Gerrit Code Review over 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#10 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#11 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#12 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#13 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#14 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#15 Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#16 Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#17 Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#18 Updated by Gerrit Code Review over 2 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#19 Updated by Gerrit Code Review over 2 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#20 Updated by Gerrit Code Review over 2 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53075

#21 Updated by Oliver Hader over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#22 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF