Bug #78422

wizard_edit doesn't work in flexforms

Added by René Fritz almost 3 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2016-10-25
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

The popup closes immediately because of a failing TCA check.

This doesn't work in 7.6. The code in 8.4 seems to be the same. See also Bug #20420

TYPO3\CMS\Backend\Controller\Wizard\EditController::main() do some checks using TCA and some GET parameters. All checks are done using TCA configuration:

$config = $GLOBALS['TCA'][$table]['columns'][$field]['config'];

Unfortunately this will not work for flexforms because we need here the configuration of the flexform field, not the parent tt_content field (for example).

Attached is a patch. I see that as a proof of concept as it will not work with NEW records and the flexform handling is a bit un-generic. The comments in the code should that make clear.

Here's a flexform field for testing:

<settings.collections>
    <TCEforms>
        <label>LLL:EXT:cms/locallang_ttc.xlf:file_collections</label>
        <config type="array">
            <type>group</type>
            <internal_type>db</internal_type>
            <allowed>sys_file_collection</allowed>
            <maxitems type="integer">999</maxitems>
            <minitems type="integer">1</minitems>
            <size type="integer">5</size>
            <wizards type="array">
                <_VERTICAL type="integer">1</_VERTICAL>
                <edit type="array">
                    <type>popup</type>
                    <title>Edit</title>
                    <module type="array">
                        <name>wizard_edit</name>
                    </module>
                    <popup_onlyOpenIfSelected type="integer">1</popup_onlyOpenIfSelected>
                    <icon>actions-open</icon>
                    <JSopenParams>height=350,width=580,status=0,menubar=0,scrollbars=1</JSopenParams>
                </edit>
            </wizards>
        </config>
    </TCEforms>
</settings.collections>

EditController.patch View (2.35 KB) René Fritz, 2016-10-25 12:45


Related issues

Related to TYPO3 Core - Bug #20420: wizard_edit.php does'nt work in flexforms Rejected 2009-05-14

Associated revisions

Revision ec30f217 (diff)
Added by Christian Kuhn about 1 year ago

[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Resolves: #78422
Releases: master, 8.7
Change-Id: Ic628824abb36e23935ad9b493a2e401fe8e734c7
Reviewed-on: https://review.typo3.org/56493
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Stephan Großberndt <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 4a6f64b5 (diff)
Added by Christian Kuhn about 1 year ago

[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Resolves: #78422
Releases: master, 8.7
Change-Id: Ic628824abb36e23935ad9b493a2e401fe8e734c7
Reviewed-on: https://review.typo3.org/58339
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Tymoteusz Motylewski almost 3 years ago

  • Category changed from Backend User Interface to FormEngine aka TCEforms

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#5 Updated by Sybille Peters over 1 year ago

So this bug is actually the same as #20420?

#6 Updated by Sybille Peters over 1 year ago

  • Related to Bug #20420: wizard_edit.php does'nt work in flexforms added

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#9 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56493

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58339

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58339

#13 Updated by Christian Kuhn about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF