Bug #78666

Dependencies from a local extension are not resolved

Added by Nicole Cordes over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Extension Manager
Target version:
-
Start date:
2016-11-12
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Following steps to reproduce:

- Try to install the attached extension

Expected result:

3 Extensions should be available and installed: a, b, and hosts_pattern (after the "I know what I'm doing" dialog was confirmed due to TYPO3 version)

Actual result:

Fatal error because hosts_pattern was not downloaded and installed.

There are several problems during the installation of an extension:

1) The information for downloading and updating dependencies is fetched to early. The queue is retrieved before local extensions were copied and its dependencies were added to the queues.
2) The queues are processed only once. This means new downloads and/or updates are not processed anymore.
3) The ordering of extensions that need to be installed is mixed up. Extensions which were added at last to the queue are dependencies of earlier ones and need to be installed first.

a_1.0.0_201611121042.zip (2.6 KB) Nicole Cordes, 2016-11-12 10:42

CMS Ext.zip (4.62 KB) Markus Klein, 2016-11-13 11:12


Related issues

Related to TYPO3 Core - Bug #78677: EM fails to install 4th level dependency of extensions Closed 2016-11-13

Associated revisions

Revision 0620f2d6 (diff)
Added by Nicole Cordes over 3 years ago

[BUGFIX] Resolves extension dependencies recursively

Currently it is not possible to install an extension which has special
sub-dependencies (e.g. dependencies of sub-extensions). During the
installation of an extension, the download information is fetched too
early and might not contain all necessary downloads. Furthermore later
installation actions add new dependencies, which have to be resolved
before any other extension can be installed.

This patch ensures all dependencies and their sub-dependencies are
fetched before the first installation. All installation information is
now correctly ordered, as the last one added has to be the first one in
the installation queue.

Resolves: #78666
Relates: #66152
Releases: master, 7.6
Change-Id: Idd9242aa1e2ecac3deb542290627fdf9c5479edc
Reviewed-on: https://review.typo3.org/50602
Tested-by: TYPO3com <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision c33d526b (diff)
Added by Nicole Cordes over 3 years ago

[BUGFIX] Resolves extension dependencies recursively

Currently it is not possible to install an extension which has special
sub-dependencies (e.g. dependencies of sub-extensions). During the
installation of an extension, the download information is fetched too
early and might not contain all necessary downloads. Furthermore later
installation actions add new dependencies, which have to be resolved
before any other extension can be installed.

This patch ensures all dependencies and their sub-dependencies are
fetched before the first installation. All installation information is
now correctly ordered, as the last one added has to be the first one in
the installation queue.

Change-Id: I6ab77a9deb883ad9eb00bfcae33dd3133695328a
Resolves: #78666
Relates: #66152
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50628
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#2 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50602

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50602

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50602

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50602

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50602

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50602

#8 Updated by Helmut Hummel over 3 years ago

  • Description updated (diff)

#9 Updated by Markus Klein over 3 years ago

Added my dependency-hell-test-set ;-)

#10 Updated by Nicole Cordes over 3 years ago

@Markus:

Your example raises a fatal error as the ext_tables.sql file is missing which ensures the table is created before any static data is imported. I fixed this issue and all is working now for me. The version of typoscript_rendering available in the system is 1.0.5

#11 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50628

#12 Updated by Nicole Cordes over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Markus Klein over 3 years ago

My issue is solved with #78677

#14 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF