TYPO3 Core

After patch https://review.typo3.org/#/c/50565/10 the pageTsConfig option to add items with icon is now broken for non selectTree render types since the svg of the icon is inlined directly and the non-tree render elements can't deal with that.

example:
TCEFORM.pages.module.addItems.12345 = staticFromPageTs
TCEFORM.pages.module.addItems.12345.icon = actions-close

maybe it's time to make the renderType="selectTree" an own type, we could review the other addItems processors along the way and kick those that don't work with trees anyway ... would mean we need an additional migration, too.

separating that would have the additional benefit that the isTargetRenderType() method could fall, which is a hack in the first place.

if we separate the tree from other select types, we could additionally inline some of the methods that are currently within the abstract into the TcaSelectItems data provider (which would make the patch a breaking patch for people who extend from that class to implement own select types).

For scenarious where selectTree goes to mm tables (like eg. pages.categories), this addItem is also a bit ... well, it is possible to add mm row entries that have no child-child counterpart. this should be documented.