Project

General

Profile

Actions
Copy link

Bug #79127

open

Responsive LiveSearch toolbar item is rendered no matter access restriction

Added by Soren Malling almost 8 years ago. Updated 6 months ago.

Status:
Needs Feedback
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2017-01-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
JavaScript
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

This is a result of a rather large work on trying to make the TYPO3 backend custom for a project.

The backend layout file Main.html (EXT:backend/Resources/Private/Templates/Backend/Main.html) contains a rendering of a LiveSearchToolbarItem even though a person might not have access

<button class="topbar-button topbar-button-search t3js-topbar-button-search">
  <core:icon identifier="actions-search" alternativeMarkupIdentifier="inline" />
</button>

This causes the search to be printed in responsive view. Since you don't have access to the toolbar item (checkAccess() method from ToolbarItemInterface) you don't get a printed LiveSearch to use.

Solution suggestion

This part of ToolbarItem rendering (including the User Settings wrench icon) could be grouped into a viewhelper to render avaialble toolbar items. Perhaps introduce a rendering API for such things (a section in Fluid, or whatever ways the rendering of the backend is going)

Actions
Copy link
 #1

Updated by Benjamin Kott over 7 years ago

  • Status changed from New to Accepted
  • Sprint Focus set to On Location Sprint
Actions
Copy link
 #2

Updated by Oliver Hader over 7 years ago

  • Tags set to JavaScript
Actions
Copy link
 #3

Updated by Susanne Moog over 7 years ago

  • Complexity set to medium
Actions
Copy link
 #4

Updated by Anja Leichsenring about 7 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions
Copy link
 #5

Updated by Benni Mack about 3 years ago

I guess we'd need to have a separate permission group for toolbar items? Live Search checks if web_list is available and then does not show the search, AFAIK?

Actions
Copy link
 #6

Updated by Benni Mack about 3 years ago

  • Status changed from Accepted to Needs Feedback
Actions
Copy link
 #7

Updated by Riccardo De Contardi 6 months ago ยท Edited

Is this one still true on Version 13.2.0-dev?

I performed the following on TYPO3 13.2.0-dev:

1) Create a BE usergroup "Editors" and DO NOT grant it the permission "Modules > Web > List"
2) Create a BE user "Editor" and DO NOT grant it the permission "Modules > Web > List"
3) Assign "Editor" to the group "Editors"
4) Switch BE User to "Editor"

Results

  • on the top toolbar I don't see anymore the Search icon

Is it sufficient?

This one looks more like a "Feature request" than a "Bug", about creating a separate type of permission for the top toolbar items, just as Benni wrote

Correct me if I am wrong, but right now ( 13.2.0-dev) the items on the right corner of the toolbar are:

- Bookmarks
- Clear cache
- Recent Documents
- Workspaces
- Help
- system information
- Livesearch
- (user) (logout/settings/etc)

1)
Clear cache
system information

are admin-only

2)
I hardly see the necessity to set up permissions to allow/negate bookmarks, help and recent documents

3)
Workspaces shows up only when the user is workspace-aware

4)
The (user) must always be present

So... the permission would just be about the livesearch :/ Or to extend to non-admin users the availability of the "clear cache" icon maybe...

Am I wrong?

Actions
Copy link

Also available in: Atom PDF