Task #79942

Move version selector view to EXT:compatibility7

Added by Benni Mack over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
Start date:
2017-02-21
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #82394: Link to Module web_txversionM1 not working if compatibility7 is not there Closed 2017-09-08

Associated revisions

Revision 14a27c0f (diff)
Added by Benni Mack over 2 years ago

[TASK] Move version selector view to EXT:compatibility7

The functionality for switching between versions and showing
all versions of a record is available through the clickmenu when
EXT:version, but not EXT:workspaces is installed.

It is only used on certain edge cases and therefor moved
to EXT:compatibility7.

Resolves: #79942
Releases: master
Change-Id: Ic54f6ff2641fcb25ab3984ebead44dc44d9d3834
Reviewed-on: https://review.typo3.org/51777
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 77ea355e (diff)
Added by Matthias Vogel almost 2 years ago

[BUGFIX] Remove legacy code for version extension

The "Display version" module of ext:version has been
moved to ext:compatibility7 with v8. The list module links
to this view but the link is dead if compat7 is not loaded.
The v8 version of the patch now checks for "loaded version,
loaded compat7, but not loaded workspaces" to render the link,
in master, this button is removed entirely

Resolves: #82394
Related: #79942
Releases: master, 8.7
Change-Id: I4e32a63b144b658f84362e25bda1cc312247367e
Reviewed-on: https://review.typo3.org/54044
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision c0b8b5de (diff)
Added by Matthias Vogel almost 2 years ago

[BUGFIX] Remove legacy code for version extension

The "Display version" module of ext:version has been
moved to ext:compatibility7 with v8. The list module links
to this view but the link is dead if compat7 is not loaded.
The v8 version of the patch now checks for "loaded version,
loaded compat7, but not loaded workspaces" to render the link,
in master, this button is removed entirely

Resolves: #82394
Related: #79942
Releases: master, 8.7
Change-Id: I4e32a63b144b658f84362e25bda1cc312247367e
Reviewed-on: https://review.typo3.org/54044
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/54050

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51777

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51777

#3 Updated by Thorsten Kahler over 2 years ago

Would somebody mind to put some information here?

#4 Updated by Benni Mack over 2 years ago

Sure.

Based on a twitter poll and a core-team internal team check some months ago, as well as the fact that this module is not maintained by somebody anymore, I decided to move this to EXT:compatibility7 to use the workspaces view for publishing / versioning records.

The whole functionality - which is versioning itself - still stays in EXT:version, and can be extended by any third-party or e.g. EXT:workspaces.

If you think this is a bad idea, I could also imagine moving the view into a TER extension, which is maintained by the community and improved further, however feedback on this BE module was rather sparse the last 3 years.

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51777

#6 Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Christian Kuhn almost 2 years ago

  • Related to Bug #82394: Link to Module web_txversionM1 not working if compatibility7 is not there added

#8 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF