Bug #81263

CKEditor: Configuration of extraPlugins is overwritten

Added by Marcus Schwemer about 1 year ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2017-05-18
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

If you add an extra plugin and configure it in the section

editor:
  config:
    <pluginname>: 
        <pluginoption>:

the configuration of the plugin in a preset is not taken into account.

Reason is that currently the configuration of the plugin overwrites the values of the output of "prepareConfigurationForEditor".

Solution is to check, whether there are values in both array. If so merge or overwrite the configuration for the editor, depending on the combination.

I will provide a patch and a extension on github to test it.

Associated revisions

Revision 63699280 (diff)
Added by Marcus Schwemer 3 months ago

[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Resolves: #81263
Releases: master,8.7
Change-Id: I4fc7c4f6f6ab40fe06e495e3ff98e067427c7d03
Reviewed-on: https://review.typo3.org/52857
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

Revision d1ad6e5d (diff)
Added by Marcus Schwemer 3 months ago

[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Resolves: #81263
Releases: master,8.7
Change-Id: I4fc7c4f6f6ab40fe06e495e3ff98e067427c7d03
Reviewed-on: https://review.typo3.org/56157
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

#3 Updated by Marcus Schwemer about 1 year ago

You can find the example plugin to experiment with here:

https://github.com/mschwemer/rte_ckeditor_wordcount

#4 Updated by Marcus Schwemer about 1 year ago

  • Subject changed from Configuration of extraPlugins is overwritten to CKEditor: Configuration of extraPlugins is overwritten
  • Category set to RTE (rtehtmlarea + ckeditor)

Here is the extension for testing: https://github.com/mschwemer/rte_ckeditor_wordcount

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

#6 Updated by Benni Mack 7 months ago

  • Sprint Focus set to On Location Sprint

#7 Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

#8 Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

#9 Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

#10 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56157

#11 Updated by Marcus Schwemer 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF