Bug #81263: CKEditor: Configuration of extraPlugins is overwritten - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #81263

closed

CKEditor: Configuration of extraPlugins is overwritten

Added by Marcus Schwemer over 7 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

RTE (rtehtmlarea + ckeditor)

Target version:

Start date:

2017-05-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

On Location Sprint

Description

If you add an extra plugin and configure it in the section

editor:
  config:
    <pluginname>: 
        <pluginoption>:

the configuration of the plugin in a preset is not taken into account.

Reason is that currently the configuration of the plugin overwrites the values of the output of "prepareConfigurationForEditor".

Solution is to check, whether there are values in both array. If so merge or overwrite the configuration for the editor, depending on the combination.

I will provide a patch and a extension on github to test it.

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions

Copy link

Updated by Marcus Schwemer over 7 years ago

You can find the example plugin to experiment with here:

https://github.com/mschwemer/rte_ckeditor_wordcount

Actions

Copy link

Updated by Marcus Schwemer over 7 years ago

Subject changed from Configuration of extraPlugins is overwritten to CKEditor: Configuration of extraPlugins is overwritten
Category set to RTE (rtehtmlarea + ckeditor)

Here is the extension for testing: https://github.com/mschwemer/rte_ckeditor_wordcount

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions

Copy link

Updated by Benni Mack almost 7 years ago

Sprint Focus set to On Location Sprint

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions

Copy link

#10

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56157

Actions

Copy link

#11