Project

General

Profile

Actions

Bug #81263

closed

CKEditor: Configuration of extraPlugins is overwritten

Added by Marcus Schwemer almost 7 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2017-05-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

If you add an extra plugin and configure it in the section

editor:
  config:
    <pluginname>: 
        <pluginoption>:

the configuration of the plugin in a preset is not taken into account.

Reason is that currently the configuration of the plugin overwrites the values of the output of "prepareConfigurationForEditor".

Solution is to check, whether there are values in both array. If so merge or overwrite the configuration for the editor, depending on the combination.

I will provide a patch and a extension on github to test it.

Actions #1

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions #2

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions #3

Updated by Marcus Schwemer almost 7 years ago

You can find the example plugin to experiment with here:

https://github.com/mschwemer/rte_ckeditor_wordcount

Actions #4

Updated by Marcus Schwemer almost 7 years ago

  • Subject changed from Configuration of extraPlugins is overwritten to CKEditor: Configuration of extraPlugins is overwritten
  • Category set to RTE (rtehtmlarea + ckeditor)

Here is the extension for testing: https://github.com/mschwemer/rte_ckeditor_wordcount

Actions #5

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions #6

Updated by Benni Mack over 6 years ago

  • Sprint Focus set to On Location Sprint
Actions #7

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions #8

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52857

Actions #10

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56157

Actions #11

Updated by Marcus Schwemer almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #13

Updated by Rémy DANIEL almost 5 years ago

This change introduced an issue: https://forge.typo3.org/issues/88302

Actions #14

Updated by Rémy DANIEL almost 5 years ago

I'm wrong, the issue described in #88302 still exists without the change introduced here.

Actions

Also available in: Atom PDF