Bug #81743

VideoTagRenderer does not support addtionalConfig Attribut playsinline

Added by Dirk Döring almost 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2017-06-29
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

<f:media additionalConfig="{playsinline:'1', controls:'0'}"/>

results in

<video><source src="source.mp4" type="video/mp4"></video>

should be

<video playsinline><source src="source.mp4" type="video/mp4"></video>

"playsinline" is an attribute which is supported by Webkit mobile browsers (iphone) to play videos inline. (https://webkit.org/blog/6784/new-video-policies-for-ios/)

There are several other attributes which arent supported neither. If you put them to "additional attributes" you get to my last reported issue (https://forge.typo3.org/issues/81741) that the media viewhelper doesnt pass the additionalAttributes or data at all.

For boolean attributes the fix is easy, just add to VideoTagRenderer.php (example for playsinline-attribute)

if (!empty($options['playsinline'])) {
            $attributes[] = 'playsinline';
        }

Associated revisions

Revision 526f1795 (diff)
Added by Markus Sommer over 1 year ago

[TASK] Reenable all additionals in video tag

Enable all additionalAttributes and additionalConfig’s to cover w3c and special spacs.

Resolves: #81743, #81741
Releases: master, 8.7
Change-Id: Ibfce2bd66e6de95eeb7c05eab160eec40ae437ef
Reviewed-on: https://review.typo3.org/53356
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53356

#2 Updated by Susanne Moog almost 2 years ago

  • Sprint Focus set to On Location Sprint

#3 Updated by Anja Leichsenring over 1 year ago

  • Sprint Focus deleted (On Location Sprint)

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53356

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55591

#6 Updated by Markus Sommer over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF