Project

General

Profile

Actions

Bug #81743

closed

VideoTagRenderer does not support addtionalConfig Attribut playsinline

Added by Dirk Döring over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2017-06-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

<f:media additionalConfig="{playsinline:'1', controls:'0'}"/>

results in

<video><source src="source.mp4" type="video/mp4"></video>

should be

<video playsinline><source src="source.mp4" type="video/mp4"></video>

"playsinline" is an attribute which is supported by Webkit mobile browsers (iphone) to play videos inline. (https://webkit.org/blog/6784/new-video-policies-for-ios/)

There are several other attributes which arent supported neither. If you put them to "additional attributes" you get to my last reported issue (https://forge.typo3.org/issues/81741) that the media viewhelper doesnt pass the additionalAttributes or data at all.

For boolean attributes the fix is easy, just add to VideoTagRenderer.php (example for playsinline-attribute)

if (!empty($options['playsinline'])) {
            $attributes[] = 'playsinline';
        }
Actions

Also available in: Atom PDF