Bug #81743
closedVideoTagRenderer does not support addtionalConfig Attribut playsinline
100%
Description
<f:media additionalConfig="{playsinline:'1', controls:'0'}"/>
results in
<video><source src="source.mp4" type="video/mp4"></video>
should be
<video playsinline><source src="source.mp4" type="video/mp4"></video>
"playsinline" is an attribute which is supported by Webkit mobile browsers (iphone) to play videos inline. (https://webkit.org/blog/6784/new-video-policies-for-ios/)
There are several other attributes which arent supported neither. If you put them to "additional attributes" you get to my last reported issue (https://forge.typo3.org/issues/81741) that the media viewhelper doesnt pass the additionalAttributes or data at all.
For boolean attributes the fix is easy, just add to VideoTagRenderer.php (example for playsinline-attribute)
if (!empty($options['playsinline'])) {
$attributes[] = 'playsinline';
}
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53356
Updated by Anja Leichsenring over 7 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Gerrit Code Review almost 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53356
Updated by Gerrit Code Review almost 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55591
Updated by Markus Sommer almost 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 526f1795a641a844b1831b50923d500a1b1d0ba2.