Project

General

Profile

Actions

Bug #81759

closed

Possible Invalid argument supplied for foreach in /EvaluateDisplayConditions.php line 171

Added by Kay Strobach almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2017-06-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

Having malformed data in the database can cause a complete breakedown of the backend edit form.

To avoid problems there should be some is_array / typeof Iterateable / is_iterateable checks around the foreach statements

https://api.typo3.org/typo3cms/current/html/_evaluate_display_conditions_8php_source.html#l00150

Problem exists in TYPO3 7.6 and 8


Files

2017-11-01_15-44-48.png (945 KB) 2017-11-01_15-44-48.png Kay Strobach, 2017-11-01 15:48
Actions #1

Updated by Susanne Moog almost 7 years ago

  • Sprint Focus set to On Location Sprint
Actions #2

Updated by Daniel Goerz almost 7 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Daniel Goerz almost 7 years ago

Achim is working on it :)

Actions #4

Updated by Daniel Goerz over 6 years ago

  • Status changed from In Progress to New
Actions #5

Updated by Anja Leichsenring over 6 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #6

Updated by Christian Kuhn over 6 years ago

  • Status changed from New to Needs Feedback

Is this still an issue since v8? I rewrote the display condition parser completely with v8 and would guess this is solved there.

For v7: Is this issue critical enough to still fix it there? If you think this should still be solved in v7, please provide some data on how to reproduce, and/or add (best) a patch to sanitize the code in question.

Actions #7

Updated by Kay Strobach over 6 years ago

I've not seen that error in one of our v8 Installations in the last days, maybe fixed now.

But in v7 this occurs during pagetree rendering.

Please see the attached stack trace

So i suggest putting a rather simple check around for each instead of having the warnings.

Actions #8

Updated by Christian Kuhn over 6 years ago

Hmm, the stack trace seems not to be formengine but user related - this might be a different issue but is not related to the formEngine display condition parser, i guess.

Actions #9

Updated by Kay Strobach over 6 years ago

Please remove my former comment.

After reevaluating - yes this still exists.

Main cause is malformed flexform data due to a problem in an extension. This should not cause the core to break.

That's why i asked for the checks.

Actions #10

Updated by Christian Kuhn over 6 years ago

Please give some more details to see if we can / should do anything about that.
  • which core versions affected? still v8, too or only v7?
  • example data which goes wrong
Actions #11

Updated by Christian Kuhn about 6 years ago

  • Status changed from Needs Feedback to Closed

Hey Kay.

As far as i can see, there has been no additional progress on this issue. I think we can close this for now. If you still need a fix in this area, please provide a stack trace and maybe a how to reproduce with a fresh ticket (maybe linking to this one here).

Actions

Also available in: Atom PDF