Feature #81901

Refactor t3editor

Added by Andreas Fernandez over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
t3editor
Target version:
Start date:
2017-07-17
Due date:
% Done:

100%

PHP Version:
7.0
Tags:
Complexity:
nightmare
Sprint Focus:
Remote Sprint

Description

EXT.t3editor's codebase is a bit aged. The main issue that CodeMirror is stale and the JavaScript implementation for our custom plugins is very fragile and the integration works "somehow".

While we're at it, CodeMirror supports a lot of addons and so-called modes, currently without the possibility to actually use them.


Related issues

Related to TYPO3 Core - Task #28853: Upgrade CodeMirror to 3.0 Closed 2011-08-08
Related to TYPO3 Core - Bug #25554: Handling of tab indentation is faulty Rejected 2009-06-30
Related to TYPO3 Core - Bug #72657: Paste into t3editor does not work Rejected 2016-01-12
Related to TYPO3 Core - Task #81885: Remove TypoScript syntax highlighting and code completion Closed 2017-07-15
Related to TYPO3 Core - Bug #82218: Wrong syntax in ExtendT3editor.rst Closed 2017-08-27
Related to TYPO3 Core - Bug #82424: T3editor: Get default mode if none is defined Closed 2017-09-09

Associated revisions

Revision a86b6374 (diff)
Added by Andreas Fernandez over 2 years ago

[!!!][FEATURE] Refactor EXT:t3editor

EXT:t3editor is refactored to use the latest CodeMirror version (at the
time of writing it's 5.28.0).
Developers are now able to easily register and use custom modes for syntax
highlighting. Also, addons for CodeMirror can be added easily.

As CodeMirror provides these already, some useful addons are already
registered, for example a search with hit annotations, fullscreen mode and
jump-to-line functionality. A positive side-effect is that a lot of custom
code was removed.

Since the architecture allows to register additional modes, the TypoScript
mode has been refactored and might be moved into a separate extension in
further iterations.

Resolves: #81901
Releases: master
Change-Id: I432d1fdb3ba1f2a0b9246207dd70843b4bdbfbd9
Reviewed-on: https://review.typo3.org/53413
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision ef8834d4 (diff)
Added by Andreas Fernandez over 2 years ago

[BUGFIX] Add missing blank lines below `code-block` in ExtendT3editor.rst

Due to invalid syntax used at the code blocks, the code is not rendered at
all. This patch adds the missing blank linkes.

Resolves: #82218
Related: #81901
Releases: master
Change-Id: Iadb034f0cfd250cf1871b65d417844e999d836e5
Reviewed-on: https://review.typo3.org/53814
Tested-by: TYPO3com <>
Reviewed-by: Sebastian Fischer <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 0d33e5a8 (diff)
Added by Andreas Fernandez over 2 years ago

[BUGFIX] T3editor: Get default mode if none is defined for a field

If a field is rendered by t3editor but no mode was defined, the t3editor
falls back to the default mode, which is `html` by default.

Resolves: #82424
Related: #81901
Releases: master
Change-Id: I4b94e5257429219ccd72a917faa170fbc56c34ad
Reviewed-on: https://review.typo3.org/54085
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>

History

#1 Updated by Andreas Fernandez over 2 years ago

  • Related to Task #28853: Upgrade CodeMirror to 3.0 added

#2 Updated by Gerrit Code Review over 2 years ago

  • Status changed from In Progress to Under Review

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#3 Updated by Georg Ringer over 2 years ago

  • Related to Bug #25554: Handling of tab indentation is faulty added

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#10 Updated by Gerrit Code Review over 2 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#11 Updated by Gerrit Code Review over 2 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#12 Updated by Gerrit Code Review over 2 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#13 Updated by Gerrit Code Review over 2 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#14 Updated by Gerrit Code Review over 2 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#15 Updated by Andreas Fernandez over 2 years ago

  • Related to Bug #72657: Paste into t3editor does not work added

#16 Updated by Andreas Fernandez over 2 years ago

  • Related to Task #81885: Remove TypoScript syntax highlighting and code completion added

#17 Updated by Gerrit Code Review over 2 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#18 Updated by Gerrit Code Review over 2 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#19 Updated by Gerrit Code Review over 2 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#20 Updated by Gerrit Code Review over 2 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#21 Updated by Gerrit Code Review over 2 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#22 Updated by Gerrit Code Review over 2 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#23 Updated by Gerrit Code Review over 2 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#24 Updated by Gerrit Code Review over 2 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#25 Updated by Gerrit Code Review over 2 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#26 Updated by Gerrit Code Review over 2 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#27 Updated by Gerrit Code Review over 2 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53413

#28 Updated by Andreas Fernandez over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#29 Updated by Andreas Fernandez over 2 years ago

  • Related to Bug #82218: Wrong syntax in ExtendT3editor.rst added

#30 Updated by Andreas Fernandez over 2 years ago

  • Related to Bug #82424: T3editor: Get default mode if none is defined added

#31 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF