Bug #82057
closedfile:current:crop does not work anymore for page media resources
100%
Description
If one adds an image in page media resources and decides to crop it,
the cropping data isn't passed through "data" anymore.
This used to work in v7!
References:
http://www.typo3-probleme.de/2017/02/01/typo3-7-6-seiteneigenschaften-bild-ressourcen-via-fluid-auslesen-1897/
http://www.typo3forum.net/discussion/78240/menue-der-unterseiten-mit-bild-jetzt-fuer-fluid-styled-content-und-richtigem-ausschnitt-crop
For Testing, I have this fsc Tempate for MenuAbstract:
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" data-namespace-typo3-fluid="true">
<f:layout name="Default" />
<f:section name="Main">
<f:if condition="{menu}">
<ul>
<f:for each="{menu}" as="page">
<li>
<a href="{page.link}" target="{page.target}" title="{page.title}">
<span>{page.title}</span>
</a>
<f:if condition="{page.data.abstract}">
<f:format.html>{page.data.abstract}</f:format.html>
</f:if>
<f:if condition="{page.data.media}">
<f:debug title="My Debug Statement" inline="1">{page}</f:debug>
<f:cObject typoscriptObjectPath="lib.pageimage" data="{page.data}" />
</f:if>
</li>
</f:for>
</ul>
</f:if>
</f:section>
</html>
And this typoscript here:
lib.pageimage = FILES lib.pageimage { references { table = pages #Seiten-ID ubergabe uid.dataWrap= {field:uid} fieldName = media } renderObj = IMAGE renderObj { file { treatIdAsReference = 1 width = 780c #height = 380c import.data = file:current:uid crop.data = file:current:crop } #altText.data = file:current:alternative altText.data = file:current:crop params = class="img-responsive" wrap = | } } }
For testing, I have the contents of "file:current:crop" in altText.data, which yields:
alt=',"selectedRatio":"NaN","focusArea":null}}'
The same typoscript works in v7 as expected, altText.data shows this result:
alt="{"x":207.1372549019608,"y":105.4656862745098,"width":265,"height":165.5,"rotate":0}"
Anybody any ideas?
If someone can point me in the right direction I will have a look.
Updated by Markus Timtner over 7 years ago
(there is a surplus "}" at the end of the typoscript, sorry for that - editing here in redmine sucks.)
Updated by Josef Glatz over 7 years ago
- Related to Bug #71164: ImageManipulation Using in Page Resources Media Relation added
Updated by Wolfgang Klinger over 7 years ago
I tested with master and the output is
{"default":{"cropArea":{"height":0.661,"width":0.9745508982035929,"x":0.02245508982035928,"y":0.207},"selectedRatio":"NaN","focusArea":null}}
which looks fine, right?
Updated by Markus Timtner over 7 years ago
Yes, this output seems right.
So are you able to see the cropped image in the frontend?
Updated by Wolfgang Klinger over 7 years ago
and I tested with 8.7.5-dev
the output is:
{"default":{"cropArea":{"height":0.5,"width":1,"x":0,"y":0.086},"selectedRatio":"4:3","focusArea":null}}
Updated by Wolfgang Klinger over 7 years ago
I just want to nail down the cause ;-)
no, the image is not cropped, but the settings seem to be there … I'll investigate further.
Updated by Markus Timtner over 7 years ago
if you need any help or testing, just contact me (@Markus Timtner) via slack -
I have a working test case ready here.
Updated by Wolfgang Klinger over 7 years ago
- Related to Story #75880: Add art direction capabilities to BE added
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Wolfgang Klinger over 7 years ago
I edited the documentation https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/pull/108
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review about 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Peter Kraume about 7 years ago
The latest patch version works fine in production! Can we get this patch in the core soon, please?
Updated by Gerrit Code Review about 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Benni Mack almost 7 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review almost 7 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717
Updated by Gerrit Code Review almost 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55147
Updated by Wolfgang Klinger almost 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4fab2d67e059cc0546aa60c47a913c981a603e0c.