Bug #82057

file:current:crop does not work anymore for page media resources

Added by Markus Timtner 16 days ago. Updated 2 days ago.

Status:
Under Review
Priority:
Must have
Category:
Image Generation
Target version:
Start date:
2017-08-08
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
fluid_styled_content, menu, typoscript, file:current:crop
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

If one adds an image in page media resources and decides to crop it,
the cropping data isn't passed through "data" anymore.

This used to work in v7!

References:
http://www.typo3-probleme.de/2017/02/01/typo3-7-6-seiteneigenschaften-bild-ressourcen-via-fluid-auslesen-1897/
http://www.typo3forum.net/discussion/78240/menue-der-unterseiten-mit-bild-jetzt-fuer-fluid-styled-content-und-richtigem-ausschnitt-crop

For Testing, I have this fsc Tempate for MenuAbstract:

<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" data-namespace-typo3-fluid="true">
<f:layout name="Default" />
<f:section name="Main">

    <f:if condition="{menu}">
        <ul>
            <f:for each="{menu}" as="page">
                <li>
                    <a href="{page.link}" target="{page.target}" title="{page.title}">
                        <span>{page.title}</span>
                    </a>
                    <f:if condition="{page.data.abstract}">
                        <f:format.html>{page.data.abstract}</f:format.html>
                    </f:if>
                    <f:if condition="{page.data.media}">
                        <f:debug title="My Debug Statement" inline="1">{page}</f:debug>
                        <f:cObject typoscriptObjectPath="lib.pageimage" data="{page.data}"  />
                    </f:if>

                </li>
            </f:for>
        </ul>
    </f:if>

</f:section>
</html>

And this typoscript here:

lib.pageimage = FILES
lib.pageimage {
        references {
            table = pages
            #Seiten-ID ubergabe
            uid.dataWrap= {field:uid}
            fieldName = media
        }
        renderObj = IMAGE
        renderObj {
            file {
                treatIdAsReference = 1
                width       = 780c
                #height      = 380c
                import.data = file:current:uid
                crop.data   = file:current:crop
            }
            #altText.data = file:current:alternative
            altText.data = file:current:crop
            params = class="img-responsive" 
            wrap = |
        }
    }
}

For testing, I have the contents of "file:current:crop" in altText.data, which yields:

alt=',"selectedRatio":"NaN","focusArea":null}}'

The same typoscript works in v7 as expected, altText.data shows this result:

alt="{&quot;x&quot;:207.1372549019608,&quot;y&quot;:105.4656862745098,&quot;width&quot;:265,&quot;height&quot;:165.5,&quot;rotate&quot;:0}" 

Anybody any ideas?
If someone can point me in the right direction I will have a look.


Related issues

Related to Core - Bug #71164: ImageManipulation Using in Page Resources Media Relation New 2015-10-30
Related to Core - Story #75880: Add art direction capabilities to BE Resolved 2017-02-23

History

#1 Updated by Markus Timtner 16 days ago

(there is a surplus "}" at the end of the typoscript, sorry for that - editing here in redmine sucks.)

#2 Updated by Josef Glatz 8 days ago

  • Related to Bug #71164: ImageManipulation Using in Page Resources Media Relation added

#3 Updated by Josef Glatz 8 days ago

  • Status changed from New to Accepted

I can confirm the issue

#4 Updated by Wolfgang Klinger 8 days ago

I tested with master and the output is

{"default":{"cropArea":{"height":0.661,"width":0.9745508982035929,"x":0.02245508982035928,"y":0.207},"selectedRatio":"NaN","focusArea":null}}

which looks fine, right?

#5 Updated by Markus Timtner 8 days ago

Yes, this output seems right.
So are you able to see the cropped image in the frontend?

#6 Updated by Wolfgang Klinger 8 days ago

and I tested with 8.7.5-dev

the output is:

{"default":{"cropArea":{"height":0.5,"width":1,"x":0,"y":0.086},"selectedRatio":"4:3","focusArea":null}}

#7 Updated by Wolfgang Klinger 8 days ago

I just want to nail down the cause ;-)
no, the image is not cropped, but the settings seem to be there … I'll investigate further.

#8 Updated by Wolfgang Klinger 8 days ago

  • Assignee set to Wolfgang Klinger

#9 Updated by Markus Timtner 8 days ago

if you need any help or testing, just contact me (@mtness) via slack -
I have a working test case ready here.

#10 Updated by Wolfgang Klinger 7 days ago

  • Related to Story #75880: Add art direction capabilities to BE added

#11 Updated by Gerrit Code Review 7 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

#12 Updated by Gerrit Code Review 7 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

#13 Updated by Gerrit Code Review 7 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

#14 Updated by Gerrit Code Review 3 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

#16 Updated by Gerrit Code Review 3 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

#17 Updated by Gerrit Code Review 2 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Also available in: Atom PDF