Bug #82068
closedInstall tool wizard Migrate all file relations from fe_user not visible
Added by Bernhard Eckl almost 7 years ago. Updated about 5 years ago.
100%
Description
I upgraded from 7.6.16 to 8.7.4 but in the install tool I can not find the upgrade wizard: Migrate all file relations from fe_user.
See: https://docs.typo3.org/typo3cms/extensions/core/8.7/Changelog/8.3/Breaking-74375-Fe_usersimageMigratedToFAL.html
Files
Bildschirmfoto 2017-09-07 um 14.54.05.png (171 KB) Bildschirmfoto 2017-09-07 um 14.54.05.png | Bernhard Eckl, 2017-09-07 14:56 |
Updated by Wouter Wolters almost 7 years ago
- Status changed from New to Needs Feedback
The update wizard is named as FrontendUserImageUpdateWizard, can you find that class?
Updated by Bernhard Eckl almost 7 years ago
Sure, I did not change the core… but the wizard is not shown in the install tool. Is there a condition for that?
Updated by Bernhard Eckl almost 7 years ago
Have a look at the screenshot.
Updated by Bernhard Eckl almost 7 years ago
I finally got it migrated now. The following things I had to do:
- in public function checkForUpdate, line 138:
return true;
otherwise the wizard would not be shown at all
- in protected function migrateField, line 298:
comment the line
$file = $this->storage->getFile($this->targetPath . $item);
and instead
$resourceFactory = \TYPO3\CMS\Core\Resource\ResourceFactory::getInstance();
$storage1 = $resourceFactory->getStorageObject(1);
$file = $storage1->getFile($this->targetPath . $item);
Otherwise no files where found.
Btw $storageUid = (int)$this->storage->getUid(); alwas returned 2, but it should be 1 (1 is my public storage named files, not fileadmin, 2 is a non public storage).
It seems that this migration wizard is buggy. Is there noone else having such difficulties with it?
Updated by Alexander Opitz over 6 years ago
- Status changed from Needs Feedback to New
Updated by Online Now! GmbH over 5 years ago
I can confirm this behaviour. This is related to #81180 and the "wizard is done" check changed in that issues. It always returns false. After reverting this change, i got the wizard visible again.
Also when getting the file storages from the system, the wizards assumes the default fileadmin storage is the first. This wasnt the case in my installation. I had to change the line from "$this->storage = $storages0;" to "$this->storage = $storages1;". So either a better check for fileadmin storage should be implemented or let the user choose the storage.
Updated by Markus Klein over 5 years ago
- Status changed from New to Accepted
- Assignee set to Markus Klein
- Target version set to next-patchlevel
- Complexity set to easy
Updated by Markus Klein over 5 years ago
- Related to Bug #81180: Frontend User upgrade wizard has flaky "done" check added
Updated by Gerrit Code Review over 5 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58895
Updated by Markus Klein over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0f4b4231189315dd113eb563f841c5734a798ee9.
Updated by Bernhard Eckl over 5 years ago
I just tried the update again, wizard is shown, but files are not migrated:
File 'uploads/pics/file.jpg' does not exist. Referencing field: fe_users.15.image. The reference was not migrated.
But the files exist.
Updated by Markus Klein over 5 years ago
@Eckl please create a new ticket for this issue. Thanks
Updated by Markus Klein over 5 years ago
@Eckl I retested this on current v8 branch and it worked. Please test again with the latest version from git and create a new ticket if it really does not work. Thank you.
Updated by Bernhard Eckl over 5 years ago
I just migrated the images manually (some images where successful by the updater, the other i have done myself). I think it was because of different sha1 for the images. Sorry, I didn’t have time to wait for a fix for another year since TYPO3 7 is not supported anymore.
Updated by Markus Klein over 5 years ago
- Target version deleted (
next-patchlevel)
Well, that's what I call supportive attitude. I was willing to dig into your problem, but fair enough.
Just to stick to the truth: I came to this ticket 28 days ago, not a year. Other than that you could have dug yourself and provide a patch. Just saying.
Updated by Bernhard Eckl over 5 years ago
I digged into the code and if I could solve it I would have provided a patch, but I couldn’t solve it. I think it is because I have different sha1 saved in sys_file. Some images where updated, some not. So I think this is just on my system since nobody else has this problem. And because I had no time for this (TYPO3 7 is not supported anymore) and I have 1000 other things to do, I decided to fix it manually to get version 8 finally. Keep calm. Just saying.