Bug #82210

ext:form multi checkbox values containing . or & result in empty frontend labels

Added by Alexander Grein almost 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2017-08-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

If a multi checkbox field contains a . (dot) or & (ampersand) as value, the rendered form only shows a checkbox without label.


Files

82210.png (62.4 KB) 82210.png Oliver Hader, 2017-09-08 14:56

Related issues

Related to TYPO3 Core - Bug #80197: EXT:form - label with periods causes PHP warningClosed2017-03-08

Actions
Related to TYPO3 Core - Bug #83403: <span></span> tag not filled in form extension for type radioClosed2017-12-20

Actions
Related to TYPO3 Core - Bug #83517: EXT:form - [FOLLOWUP] - 82210 - add documentationClosedRalf Zimmermann2018-01-09

Actions
#1

Updated by Bjoern Jacob almost 4 years ago

  • Related to Bug #80197: EXT:form - label with periods causes PHP warning added
#2

Updated by Bjoern Jacob almost 4 years ago

  • Sprint Focus set to Remote Sprint
#3

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#4

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#5

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#6

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#7

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#8

Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#9

Updated by Ralf Zimmermann almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53984

#11

Updated by Ralf Zimmermann almost 4 years ago

  • Status changed from Under Review to Resolved
#12

Updated by Oliver Hader almost 4 years ago

  • Status changed from Resolved to In Progress

Still need a follow-up...

#13

Updated by Oliver Hader almost 4 years ago

  • % Done changed from 100 to 0
#14

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#15

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#16

Updated by Oliver Hader almost 4 years ago

#17

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#18

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#19

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#20

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#21

Updated by Oliver Hader over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#22

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54621

#23

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54621

#24

Updated by Oliver Hader over 3 years ago

  • Status changed from Under Review to Resolved
#25

Updated by Felix Nagel over 3 years ago

This change will result in empty labels if the partials are overwritten. Should commits like this really be part of a patch level version?

#26

Updated by Tobias Gaertner over 3 years ago

Yea its kind of breaking change. If someone patches the minor release to 8.7.9 the form could break. The same happened wit version 8.7.8 - so I had to stay on 8.7.7

I mean fixing the template in this case is not too hard...but on a live system it could be very hard to spot this.

#27

Updated by Ralf Zimmermann over 3 years ago

  • Related to Bug #83403: <span></span> tag not filled in form extension for type radio added
#28

Updated by Ralf Zimmermann over 3 years ago

  • Related to Bug #83517: EXT:form - [FOLLOWUP] - 82210 - add documentation added
#29

Updated by Ralf Zimmermann over 3 years ago

Tobias Gaertner wrote:

Yea its kind of breaking change. If someone patches the minor release to 8.7.9 the form could break. The same happened wit version 8.7.8 - so I had to stay on 8.7.7

I mean fixing the template in this case is not too hard...but on a live system it could be very hard to spot this.

Please see and verify the fix in #83403

#30

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF