Bug #82210

ext:form multi checkbox values containing . or & result in empty frontend labels

Added by Alexander Grein almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2017-08-25
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

If a multi checkbox field contains a . (dot) or & (ampersand) as value, the rendered form only shows a checkbox without label.

82210.png View (62.4 KB) Oliver Hader, 2017-09-08 14:56


Related issues

Related to TYPO3 Core - Bug #80197: EXT:form - label with periods causes PHP warning Closed 2017-03-08
Related to TYPO3 Core - Bug #83403: <span></span> tag not filled in form extension for type radio Closed 2017-12-20
Related to TYPO3 Core - Bug #83517: EXT:form - [FOLLOWUP] - 82210 - add documentation Closed 2018-01-09

Associated revisions

Revision c801d388 (diff)
Added by Ralf Zimmermann over 2 years ago

[BUGFIX] EXT:form - fix values with dots within form editor

Fix JavaScript errors if "properties.options" array keys contain dots.

Resolves: #80197
Resolves: #82210
Resolves: #81961
Resolves: #82186
Releases: master, 8.7
Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0
Reviewed-on: https://review.typo3.org/53956
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>
Reviewed-by: Daniel Lorenz <>
Tested-by: Daniel Lorenz <>
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>

Revision b4b32de5 (diff)
Added by Ralf Zimmermann over 2 years ago

[BUGFIX] EXT:form - fix values with dots within form editor

Fix JavaScript errors if "properties.options" array keys contain dots.

Resolves: #80197
Resolves: #82210
Resolves: #81961
Resolves: #82186
Releases: master, 8.7
Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0
Reviewed-on: https://review.typo3.org/53984
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 021d393e (diff)
Added by Oliver Hader over 2 years ago

[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Resolves: #82210
Releases: master, 8.7
Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6
Reviewed-on: https://review.typo3.org/54007
Reviewed-by: Daniel Lorenz <>
Tested-by: Daniel Lorenz <>
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision 0759379c (diff)
Added by Oliver Hader over 2 years ago

[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Resolves: #82210
Releases: master, 8.7
Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6
Reviewed-on: https://review.typo3.org/54621
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 3939bdef (diff)
Added by Ralf Zimmermann over 2 years ago

[TASK] EXT:form - add documentation for #82210

Add the missing breaking rst for issue #82210.

Resolves: #83517
Related: #82210
Releases: master
Change-Id: Id157cf0678912a3008705a1fbb64a2014f2fc3f3
Reviewed-on: https://review.typo3.org/55307
Reviewed-by: Björn Jacob <>
Tested-by: Björn Jacob <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision edd210da (diff)
Added by Ralf Zimmermann over 2 years ago

[BUGFIX] EXT:form - add compatibility for issue #82210

The fix for issue #82210 implies a breaking change within a minor
release (template changes) and was never documented.

This bugfix adds some compatibility code for integrators who are using
their own templates for RadioButton and/ or MultiCheckbox form elements.

In addition, a deprecation warning is thrown and the corresponding rst
file has been added.

A different patchset adds the appropriate breaking rst file for v9.

Resolves: #83403
Related: #82210
Releases: 8.7
Change-Id: I496886631b4506f2a370cc56473de414d4c3f359
Reviewed-on: https://review.typo3.org/55306
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Bjoern Jacob over 2 years ago

  • Related to Bug #80197: EXT:form - label with periods causes PHP warning added

#2 Updated by Bjoern Jacob over 2 years ago

  • Sprint Focus set to Remote Sprint

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

#9 Updated by Ralf Zimmermann over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53984

#11 Updated by Ralf Zimmermann over 2 years ago

  • Status changed from Under Review to Resolved

#12 Updated by Oliver Hader over 2 years ago

  • Status changed from Resolved to In Progress

Still need a follow-up...

#13 Updated by Oliver Hader over 2 years ago

  • % Done changed from 100 to 0

#14 Updated by Gerrit Code Review over 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#15 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#16 Updated by Oliver Hader over 2 years ago

#17 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#18 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#19 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#20 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

#21 Updated by Oliver Hader over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#22 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54621

#23 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54621

#24 Updated by Oliver Hader over 2 years ago

  • Status changed from Under Review to Resolved

#25 Updated by Felix Nagel over 2 years ago

This change will result in empty labels if the partials are overwritten. Should commits like this really be part of a patch level version?

#26 Updated by Tobias Gaertner over 2 years ago

Yea its kind of breaking change. If someone patches the minor release to 8.7.9 the form could break. The same happened wit version 8.7.8 - so I had to stay on 8.7.7

I mean fixing the template in this case is not too hard...but on a live system it could be very hard to spot this.

#27 Updated by Ralf Zimmermann over 2 years ago

  • Related to Bug #83403: <span></span> tag not filled in form extension for type radio added

#28 Updated by Ralf Zimmermann over 2 years ago

  • Related to Bug #83517: EXT:form - [FOLLOWUP] - 82210 - add documentation added

#29 Updated by Ralf Zimmermann over 2 years ago

Tobias Gaertner wrote:

Yea its kind of breaking change. If someone patches the minor release to 8.7.9 the form could break. The same happened wit version 8.7.8 - so I had to stay on 8.7.7

I mean fixing the template in this case is not too hard...but on a live system it could be very hard to spot this.

Please see and verify the fix in #83403

#30 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF