Project

General

Profile

Actions
Copy link

Bug #82210

closed

ext:form multi checkbox values containing . or & result in empty frontend labels

Added by Alexander Grein over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2017-08-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

If a multi checkbox field contains a . (dot) or & (ampersand) as value, the rendered form only shows a checkbox without label.

Files

82210.png (62.4 KB) 82210.png Oliver Hader, 2017-09-08 14:56

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #80197: EXT:form - label with periods causes PHP warningClosed2017-03-08

Actions
Related to TYPO3 Core - Bug #83403: <span></span> tag not filled in form extension for type radioClosed2017-12-20

Actions
Related to TYPO3 Core - Bug #83517: EXT:form - [FOLLOWUP] - 82210 - add documentationClosedRalf Zimmermann2018-01-09

Actions
Actions
Copy link
 #1

Updated by Björn Jacob over 6 years ago

  • Related to Bug #80197: EXT:form - label with periods causes PHP warning added
Actions
Copy link
 #2

Updated by Björn Jacob over 6 years ago

  • Sprint Focus set to Remote Sprint
Actions
Copy link
 #3

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

Actions
Copy link
 #4

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

Actions
Copy link
 #5

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

Actions
Copy link
 #6

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

Actions
Copy link
 #7

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

Actions
Copy link
 #8

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53956

Actions
Copy link
 #9

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #10

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53984

Actions
Copy link
 #11

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #12

Updated by Oliver Hader over 6 years ago

  • Status changed from Resolved to In Progress

Still need a follow-up...

Actions
Copy link
 #13

Updated by Oliver Hader over 6 years ago

  • % Done changed from 100 to 0
Actions
Copy link
 #14

Updated by Gerrit Code Review over 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

Actions
Copy link
 #15

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

Actions
Copy link
 #16

Updated by Oliver Hader over 6 years ago

Actions
Copy link
 #17

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

Actions
Copy link
 #18

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

Actions
Copy link
 #19

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

Actions
Copy link
 #20

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54007

Actions
Copy link
 #21

Updated by Oliver Hader over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #22

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54621

Actions
Copy link
 #23

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54621

Actions
Copy link
 #24

Updated by Oliver Hader over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #25

Updated by Felix Nagel over 6 years ago

This change will result in empty labels if the partials are overwritten. Should commits like this really be part of a patch level version?

Actions
Copy link
 #26

Updated by Anonymous over 6 years ago

Yea its kind of breaking change. If someone patches the minor release to 8.7.9 the form could break. The same happened wit version 8.7.8 - so I had to stay on 8.7.7

I mean fixing the template in this case is not too hard...but on a live system it could be very hard to spot this.

Actions
Copy link
 #27

Updated by Ralf Zimmermann over 6 years ago

  • Related to Bug #83403: <span></span> tag not filled in form extension for type radio added
Actions
Copy link
 #28

Updated by Ralf Zimmermann over 6 years ago

  • Related to Bug #83517: EXT:form - [FOLLOWUP] - 82210 - add documentation added
Actions
Copy link
 #29

Updated by Ralf Zimmermann over 6 years ago

Tobias Gaertner wrote:

Yea its kind of breaking change. If someone patches the minor release to 8.7.9 the form could break. The same happened wit version 8.7.8 - so I had to stay on 8.7.7

I mean fixing the template in this case is not too hard...but on a live system it could be very hard to spot this.

Please see and verify the fix in #83403

Actions
Copy link
 #30

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF