Bug #82569

EXT:form setting attachUploads to false does not work

Added by Maik Hagenbruch almost 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
Start date:
2017-09-27
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.2
Tags:
form, finisher, upload, attachuploads, attach
Complexity:
Is Regression:
Sprint Focus:

Description

I dont know if its an bug or not, but this is not working for me. Maybe i did it wrong.

I configured my a MailToReceiverFinisher and set
attachUploads to false ( tried with [0, false, 'false'];
After sending this form the mail contains the uploaded file every time.

So i debugged in \TYPO3\CMS\Form\Domain\Finishers\EmailFinisher line 98.

$attachUploads = $this->parseOption('attachUploads');

This is always set to true. If i say
$attachUploads = false; manualy directly after this call, the attachments are NOT included in the mail.

My Config: https://pastebin.com/EXKaKVk2

This is what is saved after saving the form in backend module.


Related issues

Duplicated by TYPO3 Core - Bug #81869: Form extension doesn’t allow overriding boolean values Closed 2017-07-14

Associated revisions

Revision bc4efde7 (diff)
Added by Ralf Zimmermann almost 2 years ago

[BUGFIX] EXT:form - handle boolean finisher options

Properly store boolean form definition values. Also
boolean finisher options are returned as boolean now.

Resolves: #82569
Releases: master, 8.7
Change-Id: I1eee0c6d8eaf07534d31622025f3c954d608627b
Reviewed-on: https://review.typo3.org/54226
Tested-by: TYPO3com <>
Reviewed-by: Daniel Lorenz <>
Tested-by: Daniel Lorenz <>
Reviewed-by: Carlos Meyer <>
Tested-by: Carlos Meyer <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 9595a02b (diff)
Added by Mathias Brodala almost 2 years ago

[FOLLOWUP][BUGFIX] EXT:form - handle boolean finisher options

Fix preview rendering.

Change-Id: I0c11304175a0734b2c3690c1e460490e3733bba5
Resolves: #82569
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55026
Tested-by: TYPO3com <>
Reviewed-by: Bjoern Jacob <>
Tested-by: Bjoern Jacob <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 4624a6aa (diff)
Added by Mathias Brodala almost 2 years ago

[FOLLOWUP][BUGFIX] EXT:form - handle boolean finisher options

Fix preview rendering.

Change-Id: I0c11304175a0734b2c3690c1e460490e3733bba5
Resolves: #82569
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55036
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision a5908631 (diff)
Added by Ralf Zimmermann over 1 year ago

[BUGFIX] EXT:form - handle boolean finisher options

Properly store boolean form definition values. Also
boolean finisher options are returned as boolean now.

Resolves: #82569
Releases: master, 8.7
Change-Id: I1eee0c6d8eaf07534d31622025f3c954d608627b
Reviewed-on: https://review.typo3.org/54990
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Maik Hagenbruch almost 2 years ago

  • Category set to Form Framework

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#4 Updated by Susanne Moog almost 2 years ago

  • Duplicated by Bug #81869: Form extension doesn’t allow overriding boolean values added

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54226

#11 Updated by Ralf Zimmermann almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#14 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#15 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55026

#16 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55026

#17 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55026

#18 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55036

#19 Updated by Mathias Brodala almost 2 years ago

  • Status changed from Under Review to Resolved

#20 Updated by David Lobato over 1 year ago

Mathias Brodala wrote:

Applied in changeset 9595a02bd10c1c6b3c7a1e4aff02abf72fc4a796.

Any hope to see this change soon on 8.7?

#21 Updated by Bjoern Jacob over 1 year ago

This bugfix was not backported to v8. I am contacting the people who are able to do so.

#22 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#23 Updated by Susanne Moog over 1 year ago

  • Target version set to 8.7.10

#24 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#25 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#26 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54990

#27 Updated by Ralf Zimmermann over 1 year ago

  • Status changed from Under Review to Resolved

#28 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF