Bug #85111

HTTPS not used for cross-domain links without forceAbsoluteUrl

Added by Mathias Brodala over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-05-29
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you add a cross-domain link and set forceAbsoluteUrl the link will use HTTPS if the current site uses HTTPS.

However, the same logic is missing in case forceAbsoluteUrl is not set which will normally lead to a relative link. Cross-domain links are absolute per definition however so all links will use HTTP instead of HTTPS.

Related issues

Duplicated by TYPO3 Core - Bug #85128: typolinkEnableLinksAcrossDomains builds insecure http:// links even when SSL is enabled for current domain Closed 2018-05-31
Duplicated by TYPO3 Core - Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl Closed 2017-10-18

Associated revisions

Revision 04069575 (diff)
Added by Mathias Brodala over 2 years ago

[BUGFIX] Always prefer HTTPS for cross-domain links

This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.

Resolves: #85111
Releases: master, 8.7
Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa
Reviewed-on: https://review.typo3.org/57082
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Joerg Boesche <>
Tested-by: Joerg Boesche <>
Reviewed-by: Tobi Kretschmann <>
Tested-by: Tobi Kretschmann <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

Revision 9205db27 (diff)
Added by Mathias Brodala over 2 years ago

[BUGFIX] Always prefer HTTPS for cross-domain links

This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.

Resolves: #85111
Releases: master, 8.7
Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa
Reviewed-on: https://review.typo3.org/57086
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57082

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57086

#3 Updated by Mathias Brodala over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Helmut Hummel over 2 years ago

  • Duplicated by Bug #85128: typolinkEnableLinksAcrossDomains builds insecure http:// links even when SSL is enabled for current domain added

#5 Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

#6 Updated by Stephan Großberndt almost 2 years ago

  • Related to Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl added

#7 Updated by Stephan Großberndt almost 2 years ago

  • Related to deleted (Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl)

#8 Updated by Stephan Großberndt almost 2 years ago

  • Duplicated by Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl added

Also available in: Atom PDF