Bug #85111
HTTPS not used for cross-domain links without forceAbsoluteUrl
100%
Description
If you add a cross-domain link and set forceAbsoluteUrl
the link will use HTTPS if the current site uses HTTPS.
However, the same logic is missing in case forceAbsoluteUrl
is not set which will normally lead to a relative link. Cross-domain links are absolute per definition however so all links will use HTTP instead of HTTPS.
Related issues
Associated revisions
[BUGFIX] Always prefer HTTPS for cross-domain links
This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.
Resolves: #85111
Releases: master, 8.7
Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa
Reviewed-on: https://review.typo3.org/57082
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
[BUGFIX] Always prefer HTTPS for cross-domain links
This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.
Resolves: #85111
Releases: master, 8.7
Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa
Reviewed-on: https://review.typo3.org/57086
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
History
#1
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57082
#2
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57086
#3
Updated by Mathias Brodala over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 040695757f53b3731fec406afb9d203dcd9f3910.
#4
Updated by Helmut Hummel over 1 year ago
- Duplicated by Bug #85128: typolinkEnableLinksAcrossDomains builds insecure http:// links even when SSL is enabled for current domain added
#5
Updated by Benni Mack about 1 year ago
- Status changed from Resolved to Closed
#6
Updated by Stephan Großberndt about 1 year ago
- Related to Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl added
#7
Updated by Stephan Großberndt about 1 year ago
- Related to deleted (Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl)
#8
Updated by Stephan Großberndt about 1 year ago
- Duplicated by Bug #82797: PageLinkBuilder uses $absoluteUrlScheme outside of forceAbsoluteUrl but the scheme can only be changed when using forceAbsoluteUrl added