Bug #87160: Creating site config breaks language processing in news and vhs extensions - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #87160

closed

Creating site config breaks language processing in news and vhs extensions

Added by Jan Slusarczyk almost 6 years ago. Updated 5 months ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Localization

Target version:

Start date:

2018-12-14

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Typo3 9.5.3
Recent versions of tx_news and vhs.

Simple test site with few pages and a basic setup of news (storage folder, list, detail page separate).
One page set up with Hide default translation of page (to be visible only in the other language).
Few news articles - some of them written in default and translated, some of them written in non-default language (so they do not have a parent in default language).

Language settings in typoscript:

config {
   linkVars = L(0-1)

   sys_language_uid = 0
   language = pl
   locale_all = pl_PL.UTF-8
   htmlTag_langKey = pl

   sys_language_mode = content_fallback
   sys_language_overlay = 0
}

[globalVar = GP:L = 1]
config {
   sys_language_uid = 1
   language = en
   locale_all = en_US.UTF-8
   htmlTag_langKey = en-US
}
[END]

I have tested this setup in 8.7.21 and in 9.5.1-9.5.3 and ut works as I want. I can see a working link in vhs generated menu (v:menu.directory) to the english only page, and when I enter news list I can see both news items translated from default and those written in english (without default translation). Setting sys_language_overlay = 1 hides those news elements but the vhs menu is still working fine.

But if I generate a site config - no matter the fallback mode - strict, fallback, fallback;0,1 here's what is happening:
- I can only see news items with default translation. items without default language do not exist.
- v:menu.directory menu has a title but no link to the english only page (object passed as menu has linkTitle but no link value)
I have tried every setting I could think of and it stays this way.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Josef Glatz almost 6 years ago

Status changed from New to Needs Feedback

Can you reproduce Your problems if you use the new site configuration feature of 9.5? Because you can remove all the mentioned config.<value>‘s in your snippets. That‘s not necessary anymore. Even no condition.

Actions

Copy link

Updated by Jan Slusarczyk almost 6 years ago

My problems show up with the new site config. Everything works ok until I create config. I have tried and removed the typo script confit but it didn’t change anything. Creating the site config breaks the test site in my case...

Actions

Copy link

Updated by Florian Rachor almost 6 years ago

Jan Slusarczyk wrote:

My problems show up with the new site config. Everything works ok until I create config. I have tried and removed the typo script confit but it didn’t change anything. Creating the site config breaks the test site in my case...

I have the same problem. It seems to me that the site configuration doesn't set $GLOBALS['TSFE']>config['config']['language'] but this is used on several points, including .lang of StdWrap. In my case this doesn't work anymore:


10 = TEXT
10.value = Hello World!
10.lang.de = Hallo Welt!

The output will always be "Hello World!"

Actions

Copy link

Updated by Riccardo De Contardi almost 6 years ago

About the TypoScript snippet reported by Florian Rachor, it could be solved like this

[siteLanguage("typo3Language") == "fr"]
config.language = fr
[siteLanguage("typo3Language") == "en"]              
config.language = en
[global]  

page.110 = TEXT
page.110.value = Ciao mondo!
page.110.lang.en = Hello World!
page.110.lang.fr = Bonjour monde!

I don't know if there are more clever ways to do that without the conditions.

@Jan Schröder Slusarczyk I tried on a fresh 9.5.3 TYPO3 installation to install EXT:news and set up a minimal configuration:

1) Prerequisites: TYPO3 with two languages: italian (default) and english (additional language)
2) Install EXT:news
3) create a sysfolder "news folder" and translate it in english
3.1) create a news inside it and translate it in english
4) create a "notizie" page and translate it in english (news)
4.1) add in it a "news" plugin that shows news from the sysfolder
4.2) translate it (connected mode)

Results:¶

- the italian news is shown in italian (both in the list and in detail view)
- the english news is shown in english (both in the list and in detail view)

Actions

Copy link

Updated by Georg Ringer over 5 years ago

please test with the latest release, a lot happened there regarding fallbacks

the issue with TS has been solved as well.

Actions

Copy link

Updated by Jan Slusarczyk over 5 years ago

Georg Ringer wrote:

please test with the latest release, a lot happened there regarding fallbacks

the issue with TS has been solved as well.

I have tested my setup with 7.1.0 from TER and it still behaves the same way as before. News are being displayed ONLY if they have a default language parent version. News items created in a language of id other than 0 are not being displayed in list.

Actions

Copy link

Updated by Susanne Moog over 4 years ago

Status changed from Needs Feedback to New

Actions

Copy link

Updated by Susanne Moog over 4 years ago

Category set to Localization

Actions

Copy link

Updated by Georg Ringer over 4 years ago

Related to Bug #88372: Extbase QuerySettings ignores SiteConfiguration language settings added

Actions

Copy link

#10

Updated by Georg Ringer over 2 years ago

this is more an issue of extbase IMO and can be solved by using https://github.com/georgringer/extbase_with_no_l10n_parent

Actions

Copy link

#11

Updated by Gerrit Code Review 12 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82087

Actions

Copy link

#12

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82087

Actions

Copy link

#13

Updated by Gerrit Code Review 12 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82087

Actions

Copy link

#14

Updated by Gerrit Code Review 12 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82087

Actions

Copy link

#15

Updated by Gerrit Code Review 12 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82087

Actions

Copy link

#16

Updated by Gerrit Code Review 12 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82087

Actions

Copy link

#17

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82024

Actions

Copy link

#18