TYPO3 Core

Hi,
did you found any solution for that?

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63929

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63929

Susanne Moog wrote:

Hmm, we need to specify what exactly one would expect in CLI context, as we don't really have the public path as far as I can see.

Ok, a bit confusing:

The function getImageUri should determine the public (uri)path of a image.
Why should TYPO3_SITE_PATH the uriPrefix?

  if (isset($parsedUrl['host'])) {
            $uriPrefix = '';
        } elseif ($this->environmentService->isEnvironmentInFrontendMode()) {
            $uriPrefix = $GLOBALS['TSFE']->absRefPrefix;
        } else {
            $uriPrefix = GeneralUtility::getIndpEnv('TYPO3_SITE_PATH');
        }

This prefix is not part of the public url, it is the internal path or the "document-root". Imo this is wrong:

 else {
            $uriPrefix = GeneralUtility::getIndpEnv('TYPO3_SITE_PATH');
        }

For the CLI-Mode it should work with a site-config call, maybe with a given site root page id?

 public function getImageUri(FileInterface $image, $absolute = false, $siteRootPid = false)
 [...]
 if (is_numeric($siteRootPid)) {
   $sitefinder = GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Site\\SiteFinder');
   $uriPrefix = $sitefinder->getSiteByRootPageId($siteRootPid)->getConfiguration()['base']; 
}

Hi

Another usecase where it fails: a scheduler command send a email with a fluid standalone view.
The email template contains this:

  <f:image src="EXT:site/Resources/Public/Frontend/images/logo.png" absolute="1" />

The rendered image src is:

src="https://vendor/bin/typo3conf/ext/site/Resources/Public/Frontend/images/logo.png" 

My dirty workaround was:

// Flush GeneralUtility $indpEnvCache 
GeneralUtility::flushInternalRuntimeCaches();

// Hack to get imageService generate absolute url in mail template
$site = GeneralUtility::makeInstance(SiteFinder::class)->getSiteByIdentifier('my-site');
$_SERVER['SCRIPT_NAME'] = '/index.php';
$_SERVER['HTTP_HOST'] = $site->getRouter()->generateUri('/')->getHost();

We've made quite a lot of improvements since v9 in that area. Can you check if this still occurs in v12?

Hi Benni

Yes, I can reproduce the issue on TYPO3 12. The hack I provided still works.