Bug #88720
closed
Adding pid option to resolve function of PersistedAliasMapper (Multi-site handling and Extbase enhancer slugs)
100%
Description
Hi
Basic problem is described here (in case of news): https://stackoverflow.com/questions/55948340/typo3-how-can-i-use-the-same-slug-for-news-on-a-multidomain-setup
We are facing the problem with our own Extbase extension. There are two sites in one TYPO3 instance. The extension is managing "shop-infos". In both sites there is a shop called "Billa".
So this would be the expected result in list-view for each site:
https://www.site.one/shops/billa
https://www.site.two/shops/billa
For each site there is a folder defined which is storing the "Shop" entries.
In list mode everything is working fine.
But detail view is not correct. Both links are resolved to https://www.site.one/shops/billa (because uid of first "Billa" is lower than of second).
My opinion:
- PersistedAliasMapper is using given field to generate the slug (make uid 1 to "billa"; make uid 2 also to slug "billa"). This is happening correctly in function "generate"
- But the other direction does not respect the root site / storage folder. So my suggestion would be to add a "pid" param to the PersistedAliasMapper settings, or optional to the "resolve" funtion there. Because in the "resolve" function just the slug ist taken (and translated) and thrown to the database - searching for an uid. But in our setting, more (in fact two) uids are returned. So the lower one is given for the detail page -> wrong site.
If somebody of the core-team feels OK with my suggestion, I can also contribute it.
All the best from Vienna
Stephan
Updated by Stephan Auer almost 5 years ago
- Subject changed from Adding pid option to resolve function PersistedAliasMapper (Multi-site handling and Extbase enhancer slugs) to Adding pid option to resolve function of PersistedAliasMapper (Multi-site handling and Extbase enhancer slugs)
Updated by Georg Ringer over 4 years ago
- Status changed from New to Accepted
If you got a solution or proof of concept, please push it or add link to gist or private a patch file. Thx!
Updated by Gerrit Code Review over 4 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Robert Wolle over 4 years ago
It works!
Please release it.
We have about 70 sites in the system, which have the same news title (news-Extension).
Thank you all and keep up the good work!
Updated by Gerrit Code Review about 4 years ago
Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Gerrit Code Review about 4 years ago
Patch set 4 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Gerrit Code Review about 4 years ago
Patch set 5 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Gerrit Code Review about 4 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585
Updated by Gerrit Code Review about 4 years ago
Patch set 6 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Oliver Hader about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7f9abc7ba1ffad7cdf1686dcdb259faecf0d7938.
Updated by Gerrit Code Review about 4 years ago
- Status changed from Resolved to Under Review
Patch set 7 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586
Updated by Oliver Hader about 4 years ago
- Related to Bug #90929: Correctly initialize SiteConfiguration in functional tests added
Updated by Oliver Hader about 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset 2a1bda4f7dd33dfdcd0782afd49924925a623511.
Updated by Andreas Kienast about 4 years ago
- Related to Bug #90950: Extension Scanner is broken due to MethodArgumentRequiredMatcher.php added
Updated by Benni Mack almost 4 years ago
- Status changed from Resolved to Closed
Updated by Sven Juergens almost 4 years ago
This patch caused a different problem with the update to 9.5.16. It is now no longer possible to have a global news folder.
root
- domain1
- news
-detail
- ...
- domain3
- global news folder
all links are created correctly, but the detail view goes more, here it comes to a 404.
are there maybe new options to influence the behaviour?
Updated by Benni Mack almost 4 years ago
- Related to Bug #91235: News Detail Page 404 after upgrade 9.5.16 added
Updated by Oliver Hader almost 4 years ago
- Related to Bug #91397: PersistedAliasMapper: 404 error when linking to a detail page and linked data item is outside webroot added