Task #89463

Epic #88528: Remove switchable controller action functionality

Deprecate switchable controller actions

Added by Alexander Schnitzler 8 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Target version:
-
Start date:
2019-10-21
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #89922: Correct code-block directive Closed 2019-12-11

Associated revisions

Revision 4ab765f2 (diff)
Added by Alexander Schnitzler 6 months ago

[TASK] Deprecate switchable controller actions

The usage of switchable controller actions, both via
flexforms and typoscript, is deprecated and will be
removed in one the next major versions of TYPO3,
probably version 11.0 or 12.0.

Switchable controller actions allowed to override the
php plugin configuration and to create god plugins, i.e.
plugins that can be set into multiple different modes
and therefore take care of all possible use cases.

Every plugin should serve a single purpose, therefore
the usage of switchable controller actions is an anti
pattern which will be removed.

The switchable controller action mechanic will be
removed without replacement which means, that there
is no migration path to a similar feature.

Instead, extension authors need to create multiple,
dedicated plugins for different use cases.

Releases: master
Resolves: #89463
Change-Id: I41afac9303205f97f390f208803908177e00cda5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511
Tested-by: Richard Haeser <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Tested-by: Susanne Moog <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Susanne Moog <>

Revision 2e2083e7 (diff)
Added by Chris Müller 6 months ago

[DOCS] Correct code-block directive

The code-block directive needs two colons to be rendered
correctly.

Resolves: #89922
Related: #89463
Releases: master
Change-Id: Ida99628710cc3558a0dbdc39272e788c390ca154
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62600
Tested-by: Oliver Bartsch <>
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#2 Updated by Gerrit Code Review 8 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#3 Updated by Gerrit Code Review 8 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#4 Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#5 Updated by Gerrit Code Review 7 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#6 Updated by Gerrit Code Review 6 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#7 Updated by Gerrit Code Review 6 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#8 Updated by Gerrit Code Review 6 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511

#9 Updated by Anonymous 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Chris Müller 6 months ago

  • Related to Bug #89922: Correct code-block directive added

#11 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

#12 Updated by Dmitry Dulepov 3 months ago

@Benni

Suppose we have a news plugin with 12 custom display modes. This is a real life scenario. Currently the plugin uses switchableControllerActions. This deprecation means that instead of having one plugin with 12 selectable modes we now need 12 separate plugins, right? Does that really sounds well thought and reasonable to have a plugin selector go beyond horizon vertically?

#13 Updated by Raphael Zschorsch about 1 month ago

I must say, I agree with @Dmitry here. A custom plugin for each view of each extension could potentially result in around 20-30 plugins in the content element selector, and I imagine this would be quite confusing for editors and admins alike.

#14 Updated by Alexander Schnitzler about 1 month ago

Please have a look at my post, explaining a few things in detail:
https://gist.github.com/alexanderschnitzler/c685218feea1a8956cc3f915f7a08d0b

TLDR;
No, you don't need to create a single plugin for each controller/action combination, only for those entrypoints where controller and action params should be hidden in the url.

Also available in: Atom PDF