Bug #89555

Querying records in workspaces does not return all proper values due to "pid=-1" database

Added by Benni Mack 22 days ago. Updated 21 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
Workspaces
Start date:
2019-10-31
Due date:
% Done:

0%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Versioned records have "pid=-1" due to heavy legacy reasons before we had Doctrine DBAL and Restrictions, where one could accidentally query versioned records in their third party extension.

"pid=-1" has several drawbacks on versioned records:
- One could never query results properly by doing SQL queries on versioned records (as only equivalent live records were selected, and then overlaid)
- Unnecessary logic regarding moving and sorting due to versioned records

I propose to migrate to the proper "pid" of the live version, and look at "t3ver_oid" (live record) as all queries in the Core are already work based on this field.

An upgrade wizard then sets the "pid" field properly for all existing versions.

History

#1 Updated by Gerrit Code Review 21 days ago

  • Status changed from New to Under Review

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

#2 Updated by Gerrit Code Review 21 days ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

#3 Updated by Gerrit Code Review 21 days ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

#4 Updated by Gerrit Code Review 21 days ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

#5 Updated by Gerrit Code Review 21 days ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

#6 Updated by Gerrit Code Review 21 days ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Also available in: Atom PDF