Project

General

Profile

Actions

Bug #89555

closed

Querying records in workspaces does not return all proper values due to "pid=-1" database

Added by Benni Mack over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Start date:
2019-09-13
Due date:
2019-09-13
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Versioned records have "pid=-1" due to heavy legacy reasons before we had Doctrine DBAL and Restrictions, where one could accidentally query versioned records in their third party extension.

"pid=-1" has several drawbacks on versioned records:
- One could never query results properly by doing SQL queries on versioned records (as only equivalent live records were selected, and then overlaid)
- Unnecessary logic regarding moving and sorting due to versioned records

I propose to migrate to the proper "pid" of the live version, and look at "t3ver_oid" (live record) as all queries in the Core are already work based on this field.

An upgrade wizard then sets the "pid" field properly for all existing versions.


Related issues 7 (0 open7 closed)

Related to TYPO3 Core - Bug #91144: Copying records in pid 0 is not possible anymoreClosed2020-04-20

Actions
Related to TYPO3 Core - Bug #91851: Page module translation wizard shows duplicate records if in workspaceClosed2020-07-23

Actions
Related to TYPO3 Core - Bug #91943: Workspace preview shows correct items for sub menusClosed2020-08-06

Actions
Related to TYPO3 Core - Task #96279: Remove v9->v10 upgrade wizardsClosed2021-12-07

Actions
Related to TYPO3 Core - Task #98475: Avoid negative pid's in SQL schemaClosed2022-09-29

Actions
Follows TYPO3 Core - Bug #89122: Inconsistent evaluation of pid=-1 with workspace recordsClosedBenni Mack2019-09-112019-09-11

Actions
Precedes TYPO3 Core - Bug #91881: Massive load when deleting sys_workspace record on pid 0Closed2020-07-28

Actions
Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #2

Updated by Gerrit Code Review over 4 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #3

Updated by Gerrit Code Review over 4 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #4

Updated by Gerrit Code Review over 4 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #5

Updated by Gerrit Code Review over 4 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #7

Updated by Gerrit Code Review about 4 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #8

Updated by Gerrit Code Review about 4 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #9

Updated by Gerrit Code Review about 4 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #10

Updated by Gerrit Code Review almost 4 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #11

Updated by Gerrit Code Review almost 4 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #12

Updated by Gerrit Code Review almost 4 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #13

Updated by Gerrit Code Review almost 4 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #14

Updated by Gerrit Code Review almost 4 years ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #15

Updated by Gerrit Code Review almost 4 years ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #16

Updated by Gerrit Code Review almost 4 years ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #17

Updated by Gerrit Code Review almost 4 years ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #18

Updated by Gerrit Code Review almost 4 years ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #19

Updated by Gerrit Code Review almost 4 years ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699

Actions #20

Updated by Benni Mack almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #21

Updated by Andreas Kienast almost 4 years ago

  • Related to Bug #91144: Copying records in pid 0 is not possible anymore added
Actions #22

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed
Actions #23

Updated by Christian Kuhn over 3 years ago

  • Related to Bug #91851: Page module translation wizard shows duplicate records if in workspace added
Actions #24

Updated by Christian Kuhn over 3 years ago

  • Related to Bug #91144: Copying records in pid 0 is not possible anymore added
Actions #25

Updated by Christian Kuhn over 3 years ago

  • Related to deleted (Bug #91144: Copying records in pid 0 is not possible anymore)
Actions #26

Updated by Christian Kuhn over 3 years ago

  • Due date set to 2019-09-12
  • Start date changed from 2019-10-31 to 2019-09-12
  • Follows Bug #89122: Inconsistent evaluation of pid=-1 with workspace records added
Actions #27

Updated by Christian Kuhn over 3 years ago

  • Due date changed from 2019-09-12 to 2019-09-13
  • Start date changed from 2019-09-12 to 2019-09-13
  • Follows Bug #91881: Massive load when deleting sys_workspace record on pid 0 added
Actions #28

Updated by Christian Kuhn over 3 years ago

  • Follows deleted (Bug #91881: Massive load when deleting sys_workspace record on pid 0)
Actions #29

Updated by Christian Kuhn over 3 years ago

  • Precedes Bug #91881: Massive load when deleting sys_workspace record on pid 0 added
Actions #30

Updated by Christian Kuhn over 3 years ago

  • Related to Bug #91943: Workspace preview shows correct items for sub menus added
Actions #31

Updated by Christian Kuhn about 2 years ago

  • Related to Task #96279: Remove v9->v10 upgrade wizards added
Actions #32

Updated by Christian Kuhn over 1 year ago

  • Related to Task #98475: Avoid negative pid's in SQL schema added
Actions

Also available in: Atom PDF