Bug #91881

Massive load when deleting sys_workspace record on pid 0

Added by Christian Kuhn 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
Start date:
2020-07-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
hard
Is Regression:
Yes
Sprint Focus:

Description

This is a regression introduced by #89555 in v10 & master.

Reproduce:
  • Create a sys_workspace record on pid 0
  • Delete this sys_workspace record on pid 0

-> The database throws a massive party with all live records of all tables as guests :)

Goal:
When deleting a sys_workspace record, all records of this workspace should be deleted (soft/hard delete, depending on table TCA).

Issue:
With #89555 the restrictions of the underlying query that should find and delete all records of this workspace has been changed to also include all live records of all tables. Luckily, this does not lead to delete hazard since a check at a later point in version_clearWSID() prevents live records from being deleted within workspaces. That check however creates a log entry for each live invalid party guest ... and it happily tells the user about each one with a notice in the top right corner. That corner is too small for many thousands guests ;)

Fix:
Add a proper database restriction again. Support that with some functional test to verify correct rows are deleted.


Related issues

Related to TYPO3 Core - Bug #69310: Attempt to reset workspace failedClosed2015-08-25

Actions
Related to TYPO3 Core - Bug #61719: Warnings on flushing whole workspace with localizationsClosedOliver Hader2014-09-18

Actions
Follows TYPO3 Core - Bug #89555: Querying records in workspaces does not return all proper values due to "pid=-1" databaseClosedBenni Mack2019-09-132019-09-13

Actions
#1

Updated by Christian Kuhn 4 months ago

  • Related to Bug #69310: Attempt to reset workspace failed added
#2

Updated by Christian Kuhn 4 months ago

  • Related to Bug #61719: Warnings on flushing whole workspace with localizations added
#3

Updated by Christian Kuhn 4 months ago

  • Due date set to 2019-09-12
  • Start date changed from 2020-07-28 to 2019-09-12
  • Follows Bug #89122: Inconsistent evaluation of pid=-1 with workspace records added
#4

Updated by Christian Kuhn 4 months ago

  • Follows deleted (Bug #89122: Inconsistent evaluation of pid=-1 with workspace records)
#5

Updated by Christian Kuhn 4 months ago

  • Precedes Bug #89555: Querying records in workspaces does not return all proper values due to "pid=-1" database added
#6

Updated by Christian Kuhn 4 months ago

  • Precedes deleted (Bug #89555: Querying records in workspaces does not return all proper values due to "pid=-1" database)
#7

Updated by Christian Kuhn 4 months ago

  • Due date changed from 2019-09-12 to 2019-09-16
  • Start date changed from 2019-09-12 to 2019-09-16
  • Follows Bug #89555: Querying records in workspaces does not return all proper values due to "pid=-1" database added
#8

Updated by Christian Kuhn 4 months ago

  • Subject changed from Massive db load when deleting sys_workspace record on pid 0 to Massive load when deleting sys_workspace record on pid 0
  • Description updated (diff)
  • Due date deleted (2019-09-16)
  • Priority changed from Should have to Must have
  • Start date changed from 2019-09-16 to 2020-07-28
#9

Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65136

#10

Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65136

#11

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65136

#12

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65136

#13

Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65153

#14

Updated by Christian Kuhn 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#15

Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF