Bug #88943

Epic #88474: Page tree performance in 9.5

Pagetree taking extremely long to load for editors

Added by Karina Helena Reinhardt 4 months ago. Updated about 10 hours ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2019-08-09
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

We are testing an Upgrade from Typo3 8.7 to 9.5.8 . Our site has about 11000 pages. Our editors have permissions to see some of the pages, but not all, depending on their be group. They are allowed to edit only some pages (even less that they see). When I log in as an administrator it takes about 4 Seconds to load the pagetree. When I log in as an editor it takes about 2.5 minutes every time I refresh or reload.


Related issues

Related to TYPO3 Core - Bug #88097: Page tree data fetching is using a huge amount of memory in PHP New 2019-04-06
Related to TYPO3 Core - Bug #89687: Page tree sends unnecessary data Resolved 2019-11-14

History

#1 Updated by Karina Helena Reinhardt 4 months ago

  • Project changed from forge.typo3.org to TYPO3 Core
  • Description updated (diff)
  • Category set to Pagetree
  • TYPO3 Version set to 9
  • PHP Version set to 7.2

#2 Updated by Karina Helena Reinhardt 4 months ago

  • Related to Bug #88097: Page tree data fetching is using a huge amount of memory in PHP added

#3 Updated by Karina Helena Reinhardt 4 months ago

  • Subject changed from Pagetree taking extremly long to load for Editors to Pagetree taking extremely long to load for Editors

#4 Updated by Karina Helena Reinhardt 4 months ago

  • Subject changed from Pagetree taking extremely long to load for Editors to Pagetree taking extremely long to load for editors

#6 Updated by Karina Helena Reinhardt 4 months ago

Thanks for the hint, much appreciated!

#7 Updated by Michael Dörner 3 months ago

We have the same problem. We upgraded from TYPO3 8.7 to 9.5.9 last week. Our website has about 10,000 pages. There are four root sites and two permission groups for the page tree. The rights of the editors differ from page to page. For editors who are assigned both permission groups and have access to all pages in the page tree, it takes up to 1 minute for the page tree to load. For administrators who have access to all pages in the page tree, it only takes a few seconds.

#8 Updated by Riccardo De Contardi 3 months ago

  • Parent task set to #88474

#9 Updated by Herman Kremer 2 months ago

We also experiencing the same problem! For editors the tree is really to slow.

#10 Updated by Sebastian Müller about 2 months ago

We've got a pagetree with 15000+ pages and editors faced page tree loading times of 30 seconds.

We now patched the file web/typo3/sysext/backend/Classes/Controller/Page/TreeController.php.
In line 376 a callback for every page is called to check for fitting access rights of current user.
We do not need this check since our users are allowed to see all pages below their mount points.

After this change the page tree is returned in 1.5 seconds.

It may is a security issue for your installation if this is not OK for your editors / setup.

            $entryPoint = $repository->getTree($entryPoint, function ($page) use ($backendUser) {
                // check each page if the user has permission to access it
                return $backendUser->doesUserHaveAccess($page, Permission::PAGE_SHOW);
            });

becomes

            $entryPoint = $repository->getTree($entryPoint);

Maybe there could be a user tsconfig option be included to disable this access check?

#11 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

#12 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

#13 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

#14 Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

#15 Updated by Gerrit Code Review about 1 month ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

#16 Updated by Tymoteusz Motylewski 25 days ago

  • Related to Bug #89687: Page tree sends unnecessary data added

#17 Updated by Gerrit Code Review 7 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

#18 Updated by Gerrit Code Review about 10 hours ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086

Also available in: Atom PDF