Project

General

Profile

Actions

Bug #90250

closed

Make it possible to entirely turn off deprecation logging via configuration in TYPO3 9.x

Added by Sybille Peters about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Logging
Target version:
-
Start date:
2020-01-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
logging, deprecation
Complexity:
Is Regression:
Sprint Focus:

Description

GeneralUtility::deprecationLog() in 9.5 writes deprecation logs to deprecation file which you can't turn off

(1)

public static function deprecationLog($msg)
    {
        static::writeDeprecationLogFileEntry('GeneralUtility::deprecationLog() will be removed in TYPO3 v10.0, use "trigger_error("Given reason", E_USER_DEPRECATED);" to log deprecations.');
        trigger_error($msg, E_USER_DEPRECATED);
    }

I don't understand why this function does both: use trigger_error and writeDeprecationLogFileEntry. One would be enough, I guess.

Also, writeDeprecationLogFileEntry() writes directly to a logfile which you can't deactivate - AFAICS.

$destination = Environment::getVarPath() . '/log/deprecation_' . self::shortMD5(Environment::getProjectPath() . $GLOBALS['TYPO3_CONF_VARS']['SYS']['encryptionKey']) . '.log';

Some extensions use GeneralUtility::deprecationLog()

(2)

You can turn off (some) deprecation logging via the logging framework (I think)


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #87960: No way to disable deprecation message logged to fileClosed2019-03-20

Actions
Related to TYPO3 Core - Bug #91226: Fix wrong deprecation log callsClosedMarkus Klein2020-04-28

Actions
Actions #1

Updated by Sybille Peters about 4 years ago

Ok, I understand, there are 2 deprecations. The original deprecation that was being logged via deprecationLog and the new deprecation log about using deprecationLog() (with the also deprecated writeDeprecationLogFileEntry).

Maybe trigger_error can be used for both?

Actions #2

Updated by Sybille Peters about 4 years ago

  • Tracker changed from Bug to Task
Actions #3

Updated by Sybille Peters about 4 years ago

  • Tracker changed from Task to Bug
Actions #4

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63071

Actions #5

Updated by Sybille Peters about 4 years ago

  • Tags set to logging, deprecation
Actions #6

Updated by Sybille Peters about 4 years ago

  • Related to Bug #87960: No way to disable deprecation message logged to file added
Actions #7

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63828

Actions #8

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63071

Actions #9

Updated by Sybille Peters almost 4 years ago

  • Description updated (diff)
Actions #10

Updated by Sybille Peters almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Markus Klein almost 4 years ago

  • Related to Bug #91226: Fix wrong deprecation log calls added
Actions #12

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF