Bug #90250

Make it possible to entirely turn off deprecation logging via configuration in TYPO3 9.x

Added by Sybille Peters 26 days ago. Updated 20 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Logging
Target version:
-
Start date:
2020-01-29
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
logging, deprecation
Complexity:
Is Regression:
Sprint Focus:

Description

GeneralUtility::deprecationLog() in 9.5 writes deprecation logs to deprecation file which you can't turn off

(1)

public static function deprecationLog($msg)
    {
        static::writeDeprecationLogFileEntry('GeneralUtility::deprecationLog() will be removed in TYPO3 v10.0, use "trigger_error("Given reason", E_USER_DEPRECATED);" to log deprecations.');
        trigger_error($msg, E_USER_DEPRECATED);
    }

I don't understand why this function does both: use trigger_error and writeDeprecationLogFileEntry. One would be enough, I guess.

Also, writeDeprecationLogFileEntry() writes directly to a logfile which you can't deactivate - AFAICS.

$destination = Environment::getVarPath() . '/log/deprecation_' . self::shortMD5(Environment::getProjectPath() . $GLOBALS['TYPO3_CONF_VARS']['SYS']['encryptionKey']) . '.log';

Some extensions use GeneralUtility::deprecationLog()

(2)

You can turn off (some) deprecation logging via the logging framework (I think), but this is somewhat hidden and not inuitive or well documented. (though I may have missed this).

unset($GLOBALS['TYPO3_CONF_VARS']['LOG']['TYPO3']['CMS']['deprecations']);

Related issues

Related to TYPO3 Core - Bug #87960: No way to disable deprecation message logged to file New 2019-03-20

History

#1 Updated by Sybille Peters 26 days ago

Ok, I understand, there are 2 deprecations. The original deprecation that was being logged via deprecationLog and the new deprecation log about using deprecationLog() (with the also deprecated writeDeprecationLogFileEntry).

Maybe trigger_error can be used for both?

#2 Updated by Sybille Peters 26 days ago

  • Tracker changed from Bug to Task

#3 Updated by Sybille Peters 26 days ago

  • Tracker changed from Task to Bug

#4 Updated by Gerrit Code Review 26 days ago

  • Status changed from New to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63071

#5 Updated by Sybille Peters 20 days ago

  • Tags set to logging, deprecation

#6 Updated by Sybille Peters 20 days ago

  • Related to Bug #87960: No way to disable deprecation message logged to file added

Also available in: Atom PDF