Feature #9070
closedTranslation of index configuration titles
100%
Description
Hello,
unfortunately the possibility to translate the title of an index configuration in the plugin output is a tiny step away.
there is
// Create header if we are searching more than one indexing configuration: if (count($indexCfgs)>1) { if ($freeIndexUid>0) { list($indexCfgRec) = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows('title','index_config','uid='.intval($freeIndexUid).$this->cObj->enableFields('index_config')); $titleString = $indexCfgRec['title']; } else { $titleString = $this->pi_getLL('opt_freeIndexUid_header_'.$freeIndexUid); } $content = '<h1 class="tx-indexedsearch-category">'.htmlspecialchars($titleString).'</h1>'.$content; }
in short words: if an index cfg record is found, its title is used for output ($titleString), ELSE an LLL-value corresponding to the index cfg uid is used.
Due to the fact that index cfg records are (for the moment) not translateable but the LLL-Variant is a very nice, TYPO-Script configurable feature, I suggest doing
[...] if ($freeIndexUid>0) { list($indexCfgRec) = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows('title','index_config','uid='.intval($freeIndexUid).$this->cObj->enableFields('index_config')); $titleString = $this->pi_getLL('opt_freeIndexUid_header_'.$freeIndexUid); if(!$titleString) { $titleString = $indexCfgRec['title']; } } else { $titleString = $this->pi_getLL('opt_freeIndexUid_header_'.$freeIndexUid); } [...]
that means: if plugin.tx_indexedsearch._LOCAL_LANG.de.opt_freeIndex_Uid_header_3 (for example) is set, this value is used, otherwise the one being set as title of the index config record.
What do you think?
Updated by Oliver Hader over 11 years ago
- Project changed from 1382 to TYPO3 Core
Updated by Benni Mack about 9 years ago
- Target version changed from 7.5 to 7 LTS
Updated by Riccardo De Contardi almost 9 years ago
- Target version changed from 7 LTS to Candidate for Major Version
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61446
Updated by Gerrit Code Review about 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61446
Updated by Benni Mack about 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset dc047cf442c42678c4d32c8f4f884bc492a6f7f3.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed