Project

General

Profile

Actions

Bug #90921

closed

Contextmenu for sys_filemounts not working

Added by Georg Ringer about 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2020-04-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The contextmenu for sys_filemounts is currently broken as it tries to find a file/folder with the given UID because \TYPO3\CMS\Filelist\ContextMenu\ItemProviders\FilemountsProvider inherits from \TYPO3\CMS\Filelist\ContextMenu\ItemProviders\FileProvider.

If changed to inherit from \TYPO3\CMS\Backend\ContextMenu\ItemProviders\RecordProvider and adopting the canHandle method it works but 2 questions still open:

1) Why is there an explicit check in RecordProvider

if (in_array($this->table, ['sys_file', 'sys_filemounts', 'sys_file_storage', 'pages'], true)
            || strpos($this->table, '-drag') !== false) {
            return false;
        }

2) Why does it work for FileStorageProvider which also inherits from FileProvider

Actions #1

Updated by Riccardo De Contardi about 4 years ago

  • Category set to Backend User Interface
Actions #2

Updated by Christian Kuhn almost 3 years ago

confirmed. didn't had a deeper look, though.

Actions #3

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69800

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69800

Actions #5

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69778

Actions #6

Updated by Oliver Bartsch almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69778

Actions #8

Updated by Oliver Bartsch almost 3 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF