Project

General

Profile

Actions

Bug #91169

open

Replace file does not invalidate page cache

Added by Anonymous about 4 years ago. Updated 6 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Caching
Target version:
-
Start date:
2020-04-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.3
Tags:
Complexity:
hard
Is Regression:
Sprint Focus:

Description

An editor uploads an image in filelist. The editor references the image in a "textpic" CE on a page 1. The editor visits the frontend of page 1 and the page gets cached.

If an Editor replaces the image via "replace" functionality in filelist:

  • processed files are removed. which is correct
  • but page cache with references to the image is not invalidated

result:

textpic on page 1 shows no image anymore (as processed files were deleted and webserver says 404).

expected behaviour:

invalidate caches (e.g. pages) where file-references to fal-files are made.


Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Bug #63976: Replacing an image in File > Filelist does not trigger recreation of thumbnailClosed2014-12-18

Actions
Related to TYPO3 Core - Bug #68008: Processed image versions are not deleted when image file is replacedClosed2015-07-09

Actions
Related to TYPO3 Core - Feature #94478: Clear pages caches on referenced file replaceClosed2021-07-05

Actions
Related to TYPO3 Core - Bug #95759: Clearing cache of pages where file is linked if file was replacedClosed2021-10-24

Actions
Actions #1

Updated by Anonymous about 4 years ago

  • Related to Bug #63976: Replacing an image in File > Filelist does not trigger recreation of thumbnail added
Actions #2

Updated by Josef Glatz about 4 years ago

Just some reference:

@Ingo: Daniel Siepmann has dealt with such scenario in his article https://daniel-siepmann.de/posts/2019/typo3-content-caching.html if I can remember... There you find exactly good examples for your problem.

Actions #3

Updated by Anonymous about 4 years ago

  • Related to Bug #68008: Processed image versions are not deleted when image file is replaced added
Actions #4

Updated by Anonymous almost 4 years ago

Josef Glatz wrote:

Just some reference:

@Ingo: Daniel Siepmann has dealt with such scenario in his article https://daniel-siepmann.de/posts/2019/typo3-content-caching.html if I can remember... There you find exactly good examples for your problem.

That's right.

But this is still an issue for all FSC CEs.

Actions #5

Updated by Riccardo De Contardi over 2 years ago

  • Category set to Caching
Actions #6

Updated by Benni Mack over 2 years ago

  • Related to Feature #94478: Clear pages caches on referenced file replace added
Actions #7

Updated by Benni Mack over 2 years ago

  • Related to Bug #95759: Clearing cache of pages where file is linked if file was replaced added
Actions #8

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions #9

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions #10

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions #11

Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions #12

Updated by Christian Toffolo about 2 years ago

This extension Cache optimizer (not tested) does this and more. From the manual:

It uses an enhanced tag handling to clear the cache in these use cases:
- When a content element is changed the cache of all pages is cleared where this content element is referenced by a shortcut.
- When a file or the metadata of a file is changed the cache of all pages is cleared where this file is used in the page properties or in content elements.
- When a file is changed the directory is detected and the cache of all pages is cleared where a folder collection references it.
- When a record of an Extension is changed the cache of all pages is cleared where a related plugin is used.

IMHO all these cases should be handled by the core, not only the case where a file is replaced.

Actions #13

Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions #14

Updated by Simon Schaufelberger almost 2 years ago

  • Complexity set to hard
Actions #15

Updated by Gerrit Code Review 6 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions #16

Updated by Gerrit Code Review 6 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74442

Actions

Also available in: Atom PDF