Project

General

Profile

Actions

Bug #91177

closed

Epic #90812: Fluid-based Page Module

Fluid Page Module: Show "Inconsistent content detected flash message" only once

Added by Josef Glatz almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend User Interface
Target version:
-
Start date:
2020-04-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
fluidpagemodule
Complexity:
Is Regression:
Sprint Focus:

Description

Problem/Description

  • Scenario requirements: a page with many inconsistent content element translations
  • Open the new fluid page module with that page and activate the Language mode

A) Result: instead of one flash message, multiple flash messages are thrown in \TYPO3\CMS\Backend\View\BackendLayout\ContentFetcher::getTranslationData()

https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php#L191

B) Also the problematic content elements are not marked red.

red marked content elements in old page module (not fluid page module)

Acceptance Criteria

  • The flash message must be shown only once (for each language) like the good old page module does that already.
  • conflicting CEs must be marked red like the good old page module does that already

Files

fluidpagemodule.png (220 KB) fluidpagemodule.png Josef Glatz, 2020-04-23 11:51
91177-red.png (45.7 KB) 91177-red.png red marked content elements in old page module (not fluid page module) Josef Glatz, 2020-04-23 12:24

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #91313: Correct language title for Inconsistent content detected flash messageClosedGeorg Ringer2020-05-05

Actions
Related to TYPO3 Core - Bug #95717: Danger highlight of inconsistant translation records missingClosed2021-10-20

Actions
Actions #1

Updated by Josef Glatz almost 4 years ago

Actions #2

Updated by Josef Glatz almost 4 years ago

  • Description updated (diff)
Actions #3

Updated by Josef Glatz almost 4 years ago

  • Description updated (diff)
Actions #4

Updated by Georg Ringer almost 4 years ago

  • Related to Bug #91313: Correct language title for Inconsistent content detected flash message added
Actions #5

Updated by Claus Due almost 4 years ago

  • Assignee set to Claus Due
Actions #6

Updated by Riccardo De Contardi almost 3 years ago

I performed a test with 11.2.0-dev; It looks like that

- the warning flash message "Inconsistent content detected in language "XXXX" shows only once (I had tested with two "inconsistent" content elements on the same language, the only way I was able to see two messages was to set the inconsistent elements in two different languages, so I had a message for each language.

- the elements are still not highlighted in red (despite the warning message).

Actions #7

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71484

Actions #8

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71484

Actions #9

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71484

Actions #10

Updated by Oliver Bartsch over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Georg Ringer over 2 years ago

  • Related to Bug #95717: Danger highlight of inconsistant translation records missing added
Actions #12

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF