Bug #91316
closedMetaTagManagerRegistry instance not unique in uncached plugins
100%
Description
Reported by Aristeidis Karavas (Apr 28th at 11:51) via Slack:
https://typo3.slack.com/archives/C025BQLFA/p1588067478426300
Why in TYPO3 v10 this won't set the meta tags in frontend?
$metaTag = $this->metaTagManagerRegistry->getManagerForProperty($key);
$metaTag->addProperty($key, $metaTagValue);
If i debug it, it sets everything right but it won't be displayed in the frontend
The reason is that the PageRenderer stores a new Singleton via GeneralUtility::setSingletonInstance
in __wakeup
.
That updates MetaTagManagerRegistry
instances retrieved via GeneralUtility::makeInstance
, but not those injected via symfony DI,
where the object will already have been generated, as it is loaded during EXT:seo/ext_localconf.php loading and GeneralUtility::makeInstance
will call the DI container.
This issues happens when the PageRenderer was serialized and is unserialized for USER_INT
plugins (e.g. uncached extbase plugins).
Same applies to AssetCollector, which is serialized and unserialized as well.
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64419
Updated by Benjamin Franzke over 4 years ago
Aristeidis Karavas did now confirm that has was actually using an uncached plugin.
Updated by Georg Ringer over 4 years ago
- Related to Bug #87402: Feature-79409 renderAssetsForRequest does not work for USER_INT/uncached added
Updated by Georg Ringer over 4 years ago
- Related to Bug #88179: Meta tags and page title are unnecessarily cached in separate cache entries added
Updated by Georg Ringer over 4 years ago
- Related to Bug #91233: Cached page title is overwritten on pages with *_INT objects added
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64419
Updated by Rémy DANIEL over 4 years ago
This affects also TYPO3 9, because #88179 was backported.
Updated by Helmut Hummel over 4 years ago
DANIEL Rémy wrote:
This affects also TYPO3 9, because #88179 was backported.
Are you sure about that? As far as I can see meta tags (in contrast to title tag) are handled properly in TYPO3 9, but not in TYPO3 10
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64419
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64419
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64919
Updated by Benjamin Franzke over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9dd5e1a213ed23ab15e3b7dd8a182c872dacc745.