Bug #88179

Meta tags and page title are unnecessarily cached in separate cache entries

Added by Helmut Hummel almost 2 years ago. Updated 9 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-04-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

By concept for frontend rendering, the page title and meta tags are not meant to be stored in page cache to allow
non cachable plugins to modify those.

Currently both page title and meta tags are stored in separate cache entries, which violates the concept above
and unnecessarily tightly couples those code parts to the TypoScriptFrontendController and internal logic of it.

Therefore these caches should be removed.


Related issues

Related to TYPO3 Core - Bug #87683: TitleTagProvider always get the cached entryClosedRichard Haeser2019-02-10

Actions
Related to TYPO3 Core - Bug #86234: Missing Meta Tags on Pages with *_INT objectsClosedRichard Haeser2018-09-12

Actions
Related to TYPO3 Core - Bug #87962: Incorrect cache lifetime for MetaTag CacheClosed2019-03-20

Actions
Related to TYPO3 Core - Bug #91316: MetaTagManagerRegistry instance not unique in uncached pluginsClosedBenjamin Franzke2020-05-06

Actions
Related to TYPO3 Core - Bug #91233: Cached page title is overwritten on pages with *_INT objectsClosed2020-04-29

Actions
#1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#2

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#3

Updated by Guido Schmechel almost 2 years ago

  • Related to Bug #87683: TitleTagProvider always get the cached entry added
#4

Updated by Helmut Hummel almost 2 years ago

  • Related to Bug #86234: Missing Meta Tags on Pages with *_INT objects added
#5

Updated by Helmut Hummel almost 2 years ago

  • Related to Bug #87962: Incorrect cache lifetime for MetaTag Cache added
#6

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#7

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#8

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#9

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#10

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#11

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#12

Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#13

Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#14

Updated by Gerrit Code Review over 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520

#15

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61061

#16

Updated by Helmut Hummel over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#17

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61061

#18

Updated by Helmut Hummel over 1 year ago

  • Status changed from Under Review to Resolved
#19

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
#20

Updated by Georg Ringer 10 months ago

  • Related to Bug #91316: MetaTagManagerRegistry instance not unique in uncached plugins added
#21

Updated by DANIEL Rémy 9 months ago

It seems that a annoying issue has been introduced with this change (at least with the backport on V9).
See #91233 and #91316

#22

Updated by Helmut Hummel 9 months ago

DANIEL Rémy wrote:

It seems that a annoying issue has been introduced with this change (at least with the backport on V9).
See #91233 and #91316

This change fixed this annoying issue (alongside others): #87683
So while before uncached plugins couldn't change the title tag, now cached plugins can't change title tags, when there are uncached objects on the page :-/

#23

Updated by Helmut Hummel 8 months ago

  • Related to Bug #91233: Cached page title is overwritten on pages with *_INT objects added

Also available in: Atom PDF