Bug #91378

Slug isUniqueInTable is broken

Added by Xavier Perseguers 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2020-05-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Seems related to #91235.

Description

I edit a news item, each I click the save button the slug is updated and "-1" is appened to it.

When I manually press the refresh button, the slug is back to the normal behaviour without any useless "-1" deduplication suffix.

Full Description: https://github.com/georgringer/news/issues/1274

Problem

\TYPO3\CMS\Core\DataHandling\SlugHelper::isUniqueInTable() does not properly exclude current record, meaning a slug is NEVER unique.

Probably to be fixed in v9 as well.


Related issues

Related to TYPO3 Core - Bug #91235: News Detail Page 404 after upgrade 9.5.16Closed2020-04-29

Actions
Related to TYPO3 Core - Bug #91397: PersistedAliasMapper: 404 error when linking to a detail page and linked data item is outside webrootClosed2020-05-14

Actions
Related to TYPO3 Core - Bug #91519: News Detail Page 404 after upgrade 9.5.18Closed2020-05-29

Actions
#1

Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64482

#2

Updated by Philipp Kitzberger 9 months ago

Can confirm this one for 9.5.17 with both news and pages records (when slug-behaviour set to 'unique').

#3

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64482

#4

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64371

#5

Updated by Xavier Perseguers 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Helmut Hummel 9 months ago

  • Related to Bug #91235: News Detail Page 404 after upgrade 9.5.16 added
#7

Updated by Oliver Hader 9 months ago

  • Related to Bug #91397: PersistedAliasMapper: 404 error when linking to a detail page and linked data item is outside webroot added
#8

Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed
#9

Updated by Oliver Hader about 2 months ago

  • Related to Bug #91519: News Detail Page 404 after upgrade 9.5.18 added

Also available in: Atom PDF