Project

General

Profile

Actions

Bug #91761

open

Links with fragment and without parameters broken

Added by Robert Vock almost 4 years ago. Updated 10 months ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-07-08
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

When linking from a page with parameters to the same page without parameters but with a fragment, the link only contains the fragment. This means the browser does not follow the link, but stays on the same page.

This is a regression introduced with #89068

The problem is, that the check for queryParameters does not check if the current page has parameters:
PageLinkBuilder.php#L399

This breaks the "Return to login form" in felogin on the "Forgot password" page, if the following config is used:

plugin.tx_felogin_pi1.linkConfig.section.field = uid

The Back Link on the Forgot-Password Page will not lead back to the login form, because the tx_felogin_pi1[forgot]=1 parameter is still present in the url.

Current workaround is:

plugin.tx_felogin_pi1.linkConfig.forceAbsoluteUrl = 1

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #89068: New routing breaks fragment-only linksClosedAndreas Wolf2019-09-03

Actions
Actions #1

Updated by Robert Vock almost 4 years ago

  • Related to Bug #89068: New routing breaks fragment-only links added
Actions #2

Updated by Alexander Opitz over 3 years ago

Also working with RouteEnhancers got problematic.

We have
employees as page which shows content of listAction
employees/detail which is same page but inside the detailAction

On the employees page is a content element with a rte field which contains following link t3://page?uid=17#231 which leads to the output <a href="#231">List</a> so the user never comes back from RouteEnhancers subpath.

Actions #3

Updated by Oliver Hader over 1 year ago

  • Sprint Focus set to On Location Sprint
Actions #4

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #7

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #8

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #9

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #10

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #11

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #12

Updated by Gerrit Code Review about 1 year ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #13

Updated by Gerrit Code Review about 1 year ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76794

Actions #14

Updated by Benni Mack 11 months ago

  • Status changed from Under Review to Accepted
Actions #15

Updated by Benni Mack 10 months ago

  • Sprint Focus deleted (On Location Sprint)
Actions

Also available in: Atom PDF