Project

General

Profile

Actions

Bug #91880

closed

Routing for actions without parameters broken

Added by Robert Vock over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-07-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

I have the following Routing Configuration:

  RegistrationPlugin:
    type: Extbase
    extension: SfRegister
    plugin: Form
    defaultController: 'FeuserCreate::form'
    routes:
      -
        routePath: '/'
        _controller: 'FeuserCreate::form'
      -
        routePath: '/speichern'
        _controller: 'FeuserCreate::save'
      -
        routePath: '/bestaetigen/{user}/{hash}'
        _controller: 'FeuserCreate::confirm'
        _arguments:
          user: user
          hash: hash

Until TYPO3 9.5.19 this generated pretty URLs for the save action:
/registrierung/speichern

With TYPO3 9.5.20 Update the controller and action parameters are not encoded anymore:
/registrierung?tx_sfregister_form%5Baction%5D=save&tx_sfregister_form%5Bcontroller%5D=FeuserCreate&cHash=d0b4e36e4798e4ce992891ce20b160f9

It appears this bug has been introduced with #90924:
ExtbasePluginEnhancer.php:149

If I change the condition, the URL works fine:

if ($diff = array_diff_key($variables, $mergedParams)) {


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #90924: Maximum route parameters always appendedClosed2020-04-01

Actions
Actions #1

Updated by Robert Vock over 3 years ago

  • Related to Bug #90924: Maximum route parameters always appended added
Actions #2

Updated by Oliver Hader over 3 years ago

Good catch, in the case of ExtbaseEnhancer path variables are implicitly given at least for the controller/action pair. Thus, fine for ExtbaseEnhancer to remove the $variables === [] guard.

Actions #3

Updated by Oliver Hader over 3 years ago

  • Status changed from New to Accepted
  • Complexity set to medium
Actions #4

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65134

Actions #5

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65134

Actions #6

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65232

Actions #7

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65233

Actions #8

Updated by Oliver Hader over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF