Bug #91880
closedRouting for actions without parameters broken
100%
Description
I have the following Routing Configuration:
RegistrationPlugin:
type: Extbase
extension: SfRegister
plugin: Form
defaultController: 'FeuserCreate::form'
routes:
-
routePath: '/'
_controller: 'FeuserCreate::form'
-
routePath: '/speichern'
_controller: 'FeuserCreate::save'
-
routePath: '/bestaetigen/{user}/{hash}'
_controller: 'FeuserCreate::confirm'
_arguments:
user: user
hash: hash
Until TYPO3 9.5.19 this generated pretty URLs for the save action:/registrierung/speichern
With TYPO3 9.5.20 Update the controller and action parameters are not encoded anymore:/registrierung?tx_sfregister_form%5Baction%5D=save&tx_sfregister_form%5Bcontroller%5D=FeuserCreate&cHash=d0b4e36e4798e4ce992891ce20b160f9
It appears this bug has been introduced with #90924:
ExtbasePluginEnhancer.php:149
If I change the condition, the URL works fine:
if ($diff = array_diff_key($variables, $mergedParams)) {
Updated by Robert Vock about 4 years ago
- Related to Bug #90924: Maximum route parameters always appended added
Updated by Oliver Hader about 4 years ago
Good catch, in the case of ExtbaseEnhancer
path variables are implicitly given at least for the controller/action pair. Thus, fine for ExtbaseEnhancer
to remove the $variables === []
guard.
Updated by Oliver Hader about 4 years ago
- Status changed from New to Accepted
- Complexity set to medium
Updated by Gerrit Code Review about 4 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65134
Updated by Gerrit Code Review about 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65134
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65232
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65233
Updated by Oliver Hader about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d572562dd38f1e9c237528d7aa5f027f782a85fa.